From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 351FEC282C4 for ; Sat, 9 Feb 2019 17:28:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 009DB2192B for ; Sat, 9 Feb 2019 17:28:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727724AbfBIR2h (ORCPT ); Sat, 9 Feb 2019 12:28:37 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:46946 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727655AbfBIR2h (ORCPT ); Sat, 9 Feb 2019 12:28:37 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D62EF14AE849C; Sat, 9 Feb 2019 09:28:36 -0800 (PST) Date: Sat, 09 Feb 2019 09:28:34 -0800 (PST) Message-Id: <20190209.092834.203797146180282188.davem@davemloft.net> To: vakul.garg@nxp.com Cc: netdev@vger.kernel.org, borisp@mellanox.com, aviadye@mellanox.com, davejwatson@fb.com, doronrk@fb.com Subject: Re: [PATCH net-next] net/tls: Disable async decrytion for tls1.3 From: David Miller In-Reply-To: <20190209075110.19881-1-vakul.garg@nxp.com> References: <20190209075110.19881-1-vakul.garg@nxp.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 09 Feb 2019 09:28:37 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vakul Garg Date: Sat, 9 Feb 2019 07:53:28 +0000 > Function tls_sw_recvmsg() dequeues multiple records from stream parser > and decrypts them. In case the decryption is done by async accelerator, > the records may get submitted for decryption while the previous ones may > not have been decryted yet. For tls1.3, the record type is known only > after decryption. Therefore, for tls1.3, tls_sw_recvmsg() may submit > records for decryption even if it gets 'handshake' records after 'data' > records. These intermediate 'handshake' records may do a key updation. > By the time new keys are given to ktls by userspace, it is possible that > ktls has already submitted some records i(which are encrypted with new > keys) for decryption using old keys. This would lead to decrypt failure. > Therefore, async decryption of records should be disabled for tls1.3. > > Fixes: 130b392c6cd6b ("net: tls: Add tls 1.3 support") > Signed-off-by: Vakul Garg Applied, thank you.