From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F7B8C282C4 for ; Sat, 9 Feb 2019 17:29:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 752282192D for ; Sat, 9 Feb 2019 17:29:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727772AbfBIR3r (ORCPT ); Sat, 9 Feb 2019 12:29:47 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:46982 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726979AbfBIR3q (ORCPT ); Sat, 9 Feb 2019 12:29:46 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5895A14AE8701; Sat, 9 Feb 2019 09:29:46 -0800 (PST) Date: Sat, 09 Feb 2019 09:29:45 -0800 (PST) Message-Id: <20190209.092945.2258148508309937100.davem@davemloft.net> To: hkallweit1@gmail.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next] net: phy: remove unneeded masking of PHY register read results From: David Miller In-Reply-To: References: <75c9d8ee-582f-f247-7595-d8732ac26c20@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 09 Feb 2019 09:29:46 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Heiner Kallweit Date: Sat, 9 Feb 2019 09:46:53 +0100 > PHY registers are only 16 bits wide, therefore, if the read was > successful, there's no need to mask out the higher 16 bits. > > Signed-off-by: Heiner Kallweit > Reviewed-by: Andrew Lunn Applied, thanks Heiner.