From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com
Subject: Re: [PATCH net-next 2/4] devlink: don't allocate attrs on the stack
Date: Sat, 9 Feb 2019 09:35:57 +0100 [thread overview]
Message-ID: <20190209083557.GF2353@nanopsycho> (raw)
In-Reply-To: <20190209031611.1102-3-jakub.kicinski@netronome.com>
Sat, Feb 09, 2019 at 04:16:09AM CET, jakub.kicinski@netronome.com wrote:
>Number of devlink attributes has grown over 128, causing the
>following warning:
>
>../net/core/devlink.c: In function ‘devlink_nl_cmd_region_read_dumpit’:
>../net/core/devlink.c:3740:1: warning: the frame size of 1064 bytes is larger than 1024 bytes [-Wframe-larger-than=]
> }
> ^
>
>Since the number of attributes is only going to grow allocate
>the array dynamically.
>
>Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
next prev parent reply other threads:[~2019-02-09 8:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-09 3:16 [PATCH net-next 0/4] devlink: minor tweaks to reported device info Jakub Kicinski
2019-02-09 3:16 ` [PATCH net-next 1/4] devlink: fix condition for compat " Jakub Kicinski
2019-02-09 8:33 ` Jiri Pirko
2019-02-09 3:16 ` [PATCH net-next 2/4] devlink: don't allocate attrs on the stack Jakub Kicinski
2019-02-09 8:35 ` Jiri Pirko [this message]
2019-02-09 3:16 ` [PATCH net-next 3/4] nfp: devlink: rename vendor to manufacture Jakub Kicinski
2019-02-09 8:36 ` Jiri Pirko
2019-02-11 2:53 ` Jakub Kicinski
2019-02-09 3:16 ` [PATCH net-next 4/4] nfp: devlink: include vendor/product info in serial number Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190209083557.GF2353@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).