From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8917DC282C4 for ; Sat, 9 Feb 2019 08:46:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 568C62084D for ; Sat, 9 Feb 2019 08:46:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="17LawH/+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726873AbfBIIp7 (ORCPT ); Sat, 9 Feb 2019 03:45:59 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:38253 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726047AbfBIIp6 (ORCPT ); Sat, 9 Feb 2019 03:45:58 -0500 Received: by mail-wm1-f67.google.com with SMTP id v26so7323740wmh.3 for ; Sat, 09 Feb 2019 00:45:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1rPLcz9XSSZUEk6epG1/6XPp6RLZj8TNEVmInBN/1g8=; b=17LawH/+azV4voUuQ9JWXOsVFB4HMQ0oY0isZFQHKIa8GQigtYZriVqriHxYF8S1sr ekzjedhru3j3itBFulHy8y/YG6+5eXhngaO2WPTILMhZwu3ahsjRnfq0/Uer7ZSNBxti l+ySR00RwK0+INcyqs7ZkuSg2tKdONchqcoAt8D8jBTD05h20u1Lg/Aj7IzFssRqi4Hh JR+q0h1EzmJ4ZCLRNpBWQZ9A+Wnu7dpellycM0mMKDHzL47TDTfcD/Jqr7Vnzpb49faX YGY4E2X50kzJhsiI0OsIFupYsIAv7+WJBb1XNrIEqbY7lgbserYNP7W1BrwjADOjPjQb g2ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1rPLcz9XSSZUEk6epG1/6XPp6RLZj8TNEVmInBN/1g8=; b=GdsSVQiaKTGFzVYsehGw9fXnNVT2IjFxyoISz49n43xpfb1RBbDlkflgCfloLtvrs0 cQBqgu3ginE6qudEu96D7kLcG5cmb47Kj9F5dxLiqgSG9kd9oT2ijQYQO1rCnfw/m8R2 7SLzQsucvOB7RcZ3hwlohke0n2XQ5S5gOE09avR6gUOjglDhAn30Cj1iOt4cZwER9ayr aDfAW65GvMxUH/DPAu+1pp1odbDvHBXqF7MjmGi4uYqgIsNScEWuxjSV1o5j1T/hCRxs fvc5OaPKw54YDoM2jl6Qk6h8RaLEGvhuGOfskqetRrDzTZ1rzH7Y52+VtWVV4yk94WKn +SdQ== X-Gm-Message-State: AHQUAuZj+Ca8e3xL7fFXQN848hxwxwAv2bw0VfCpXgRmibTq5jIkUmZP TdRYpiFQ/F7mqr+Nu6mzKwLyKQ== X-Google-Smtp-Source: AHgI3IZvQc8GLqO9GDiEg7QvrU2GpmNdehzrWd6whfBd1x3glggk1ADomeQP/9sCUDTa2oWpxwjIHw== X-Received: by 2002:a1c:f701:: with SMTP id v1mr1993006wmh.153.1549701956883; Sat, 09 Feb 2019 00:45:56 -0800 (PST) Received: from localhost (ip-94-113-219-55.net.upcbroadband.cz. [94.113.219.55]) by smtp.gmail.com with ESMTPSA id t4sm6308952wrb.64.2019.02.09.00.45.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 09 Feb 2019 00:45:56 -0800 (PST) Date: Sat, 9 Feb 2019 09:36:44 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [PATCH net-next 3/4] nfp: devlink: rename vendor to manufacture Message-ID: <20190209083644.GG2353@nanopsycho> References: <20190209031611.1102-1-jakub.kicinski@netronome.com> <20190209031611.1102-4-jakub.kicinski@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190209031611.1102-4-jakub.kicinski@netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Sat, Feb 09, 2019 at 04:16:10AM CET, jakub.kicinski@netronome.com wrote: >Vendor may sound ambiguous, let's rename the fab string to >"board.manufacture". > >Signed-off-by: Jakub Kicinski >Reviewed-by: Dirk van der Merwe >--- > drivers/net/ethernet/netronome/nfp/nfp_devlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/ethernet/netronome/nfp/nfp_devlink.c b/drivers/net/ethernet/netronome/nfp/nfp_devlink.c >index dddbb0575be9..6e15e216732a 100644 >--- a/drivers/net/ethernet/netronome/nfp/nfp_devlink.c >+++ b/drivers/net/ethernet/netronome/nfp/nfp_devlink.c >@@ -178,7 +178,7 @@ static const struct nfp_devlink_versions_simple { > } nfp_devlink_versions_hwinfo[] = { > { DEVLINK_INFO_VERSION_GENERIC_BOARD_ID, "assembly.partno", }, > { DEVLINK_INFO_VERSION_GENERIC_BOARD_REV, "assembly.revision", }, >- { "board.vendor", /* fab */ "assembly.vendor", }, >+ { "board.manufacture", "assembly.vendor", }, I wonder, why this is not among generic? > { "board.model", /* code name */ "assembly.model", }, > }; > >-- >2.19.2 >