From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 151CCC282C2 for ; Sun, 10 Feb 2019 20:34:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB03B2145D for ; Sun, 10 Feb 2019 20:34:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="kwVwnMP5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726134AbfBJUeq (ORCPT ); Sun, 10 Feb 2019 15:34:46 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:44956 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725958AbfBJUeq (ORCPT ); Sun, 10 Feb 2019 15:34:46 -0500 Received: by mail-pg1-f195.google.com with SMTP id y1so3991867pgk.11 for ; Sun, 10 Feb 2019 12:34:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CLBWgeI8j6ZmBN6V5Aj+mIEgkBTNKgyeKOimsunB2NM=; b=kwVwnMP5jQgfx/4kmHa2yCMKitk8gXYErATuJR7kQaLvdKK+kcIljQARfzItJIxegB S0Ni5qz5i0yWpJH5Lcc1Sik5Sl42obUHMK5nr/5Gov/a97IJ5CFg0+ZbyTuoUMz6gwLe Ha60ecMl9gRW1LCQ1Dq5nEC97jsxv1I9z1e5bkel7gcSvEdfj/KCAb0v2ceFlW7YKZDe axBciiN7Crk0RuNghvjaXy+ndZQkG7BYp4SQyr7jzywB+uc7r+xBT+vB5GqGY+Df1EM9 DUckCf+dyKNPji2W6229HQ669vz3d4njvUmDTS225wkMQ9qr5+CRfgY3IqqQm7g+bp62 3yIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CLBWgeI8j6ZmBN6V5Aj+mIEgkBTNKgyeKOimsunB2NM=; b=hsVrJOq5sFd9ZVduaHNqeh9Alxa4BbnT0dGpcIfIzBDvX2MtsrYubQHsmHUDkS/iL8 vdxouslS3aF34cq3ByoBAYthIFHsPV1pXM+D3Lq+4o3NE95zSNEp/DABFeSuhpYGGB5j UvpUctiV5m0SFs+VvyJnFAroRT2XXOv58OYahaD+myvqGHKVb4WqVzwZENUnPYMop3Ex G1cDu9UdCpBZ1sSjMw9YFcLUgNNOMWCScYtJjj69c8S5YC6WdhCF14/a2LVAFWeEORVL hClb26lk/smpgi+nNPyRn+4v4/mKN08/4XVqSb7anvjFpSrPWXVIexjBadKPIU2N3uh6 T+og== X-Gm-Message-State: AHQUAuZ82czwTs78u4X0QN15wcPSu07NU3JsPEPmq/wbb7Pa6R32w1HZ U20VjqwjDtK4JgjJHNwMThg4ZTX5m4U= X-Google-Smtp-Source: AHgI3Ia7A3w+in2IYIfgmybyT2WdZy+mAbUfP5+nCMsiI9T31F83C7T3i6IUAVdaKKAe5E89Jhrg6w== X-Received: by 2002:a63:f553:: with SMTP id e19mr30047443pgk.87.1549830885610; Sun, 10 Feb 2019 12:34:45 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id j11sm3708162pfh.168.2019.02.10.12.34.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 10 Feb 2019 12:34:45 -0800 (PST) Date: Sun, 10 Feb 2019 12:34:43 -0800 From: Stephen Hemminger To: Aya Levin Cc: David Ahern , netdev@vger.kernel.org, "David S. Miller" , Jiri Pirko , Moshe Shemesh , Eran Ben Elisha , Tal Alon , Ariel Almog Subject: Re: [PATCH for-next 3/4] devlink: fix boolean JSON print Message-ID: <20190210123443.206a2a7e@hermes.lan> In-Reply-To: <1549823329-10377-4-git-send-email-ayal@mellanox.com> References: <1549532202-943-1-git-send-email-eranbe@mellanox.com> <1549823329-10377-1-git-send-email-ayal@mellanox.com> <1549823329-10377-4-git-send-email-ayal@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, 10 Feb 2019 20:28:48 +0200 Aya Levin wrote: > This patch removes the inverted commas from boolean values in JSON > format: true/false instead of "true"/"false". > > Signed-off-by: Aya Levin > Reviewed-by: Moshe Shemesh > --- > devlink/devlink.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/devlink/devlink.c b/devlink/devlink.c > index 46e2e41c5dfd..a433883f1b2b 100644 > --- a/devlink/devlink.c > +++ b/devlink/devlink.c > @@ -1605,10 +1605,10 @@ static void pr_out_str(struct dl *dl, const char *name, const char *val) > > static void pr_out_bool(struct dl *dl, const char *name, bool val) > { > - if (val) > - pr_out_str(dl, name, "true"); > + if (dl->json_output) > + jsonw_bool_field(dl->jw, name, val); > else > - pr_out_str(dl, name, "false"); > + pr_out_str(dl, name, val ? "true" : "false"); > } > > static void pr_out_uint(struct dl *dl, const char *name, unsigned int val) There is already print_bool in json_print why is that not used?