From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=RTe9=QT=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id D6855C169C4
	for <netdev@archiver.kernel.org>; Tue, 12 Feb 2019 02:36:30 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id A5A5A206BB
	for <netdev@archiver.kernel.org>; Tue, 12 Feb 2019 02:36:30 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727530AbfBLCg3 (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Mon, 11 Feb 2019 21:36:29 -0500
Received: from shards.monkeyblade.net ([23.128.96.9]:47090 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727265AbfBLCg3 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 11 Feb 2019 21:36:29 -0500
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 5A9FD14C09F16;
        Mon, 11 Feb 2019 18:36:28 -0800 (PST)
Date:   Mon, 11 Feb 2019 18:36:24 -0800 (PST)
Message-Id: <20190211.183624.1085166229826606719.davem@davemloft.net>
To:     hoang.h.le@dektech.com.au
Cc:     tipc-discussion@lists.sourceforge.net, jon.maloy@ericsson.com,
        maloy@donjonn.com, ying.xue@windriver.com, netdev@vger.kernel.org
Subject: Re: [net] tipc: fix skb may be leaky in tipc_link_input
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190211021828.6145-1-hoang.h.le@dektech.com.au>
References: <20190211021828.6145-1-hoang.h.le@dektech.com.au>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 11 Feb 2019 18:36:28 -0800 (PST)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: Hoang Le <hoang.h.le@dektech.com.au>
Date: Mon, 11 Feb 2019 09:18:28 +0700

> When we free skb at tipc_data_input, we return a 'false' boolean.
> Then, skb passed to subcalling tipc_link_input in tipc_link_rcv,
> 
> <snip>
> 1303 int tipc_link_rcv:
> ...
> 1354    if (!tipc_data_input(l, skb, l->inputq))
> 1355        rc |= tipc_link_input(l, skb, l->inputq);
> </snip>
> 
> Fix it by simple changing to a 'true' boolean when skb is being free-ed.
> Then, tipc_link_rcv will bypassed to subcalling tipc_link_input as above
> condition.
> 
> Acked-by: Ying Xue <ying.xue@windriver.com>
> Acked-by: Jon Maloy <maloy@donjonn.com>
> Signed-off-by: Hoang Le <hoang.h.le@dektech.com.au>

Applied, thanks.