From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 564EEC282C4 for ; Tue, 12 Feb 2019 17:25:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 301B6222C2 for ; Tue, 12 Feb 2019 17:25:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730728AbfBLRZx (ORCPT ); Tue, 12 Feb 2019 12:25:53 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:55034 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728101AbfBLRZw (ORCPT ); Tue, 12 Feb 2019 12:25:52 -0500 Received: from localhost (96-89-128-221-static.hfc.comcastbusiness.net [96.89.128.221]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 38A5814C3D453; Tue, 12 Feb 2019 09:25:52 -0800 (PST) Date: Tue, 12 Feb 2019 09:25:51 -0800 (PST) Message-Id: <20190212.092551.40841100078020408.davem@davemloft.net> To: rmk+kernel@armlinux.org.uk Cc: andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com, netdev@vger.kernel.org Subject: Re: [PATCH] net: phylink: avoid resolving link state too early From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 12 Feb 2019 09:25:52 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Russell King Date: Mon, 11 Feb 2019 15:04:24 +0000 > During testing on Armada 388 platforms, it was found with a certain > module configuration that it was possible to trigger a kernel oops > during the module load process, caused by the phylink resolver being > triggered for a currently disabled interface. > > This problem was introduced by changing the way the SFP registration > works, which now can result in the sfp link down notification being > called during phylink_create(). > > Fixes: b5bfc21af5cb ("net: sfp: do not probe SFP module before we're attached") > Signed-off-by: Russell King Applied, thanks Russell.