From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EFB0C282C4 for ; Tue, 12 Feb 2019 17:35:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25613222C4 for ; Tue, 12 Feb 2019 17:35:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728875AbfBLRfa (ORCPT ); Tue, 12 Feb 2019 12:35:30 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:55292 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726480AbfBLRf3 (ORCPT ); Tue, 12 Feb 2019 12:35:29 -0500 Received: from localhost (96-89-128-221-static.hfc.comcastbusiness.net [96.89.128.221]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 3275510279DB3; Tue, 12 Feb 2019 09:35:29 -0800 (PST) Date: Tue, 12 Feb 2019 09:35:28 -0800 (PST) Message-Id: <20190212.093528.434716184709943154.davem@davemloft.net> To: vakul.garg@nxp.com Cc: netdev@vger.kernel.org, borisp@mellanox.com, aviadye@mellanox.com, davejwatson@fb.com, doronrk@fb.com Subject: Re: [PATCH net-next] net/tls: Do not use async crypto for non-data records From: David Miller In-Reply-To: <20190211112845.27747-1-vakul.garg@nxp.com> References: <20190211112845.27747-1-vakul.garg@nxp.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 12 Feb 2019 09:35:29 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vakul Garg Date: Mon, 11 Feb 2019 11:31:05 +0000 > Addition of tls1.3 support broke tls1.2 handshake when async crypto > accelerator is used. This is because the record type for non-data > records is not propagated to user application. Also when async > decryption happens, the decryption does not stop when two different > types of records get dequeued and submitted for decryption. To address > it, we decrypt tls1.2 non-data records in synchronous way. We check > whether the record we just processed has same type as the previous one > before checking for async condition and jumping to dequeue next record. > > Fixes: 130b392c6cd6b ("net: tls: Add tls 1.3 support") > Signed-off-by: Vakul Garg Applied, thanks.