From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16FF2C282C4 for ; Tue, 12 Feb 2019 12:17:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D2D7B20863 for ; Tue, 12 Feb 2019 12:17:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549973838; bh=v3Aa+BNDbmRQo4KNNK+wAyvdBSf0wWM03YRS4gFFGa8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=2IaOtGJpcI2+W/2VS6qjFQm27otQCfaEXNa4SfYutjSaop/2eLum9Op2O9shhUF/A ino7uFvCmvPtWuA8SnKMUNE6Cgi2aRX0DMgMsEj5N7T0pTQBBsCZy6Q/2wjakTMaTp d3RqOvzUAyqea7K6OEgsSr5ItLO/qlm9kRhgFjrQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728365AbfBLMRR (ORCPT ); Tue, 12 Feb 2019 07:17:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:56080 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726192AbfBLMRR (ORCPT ); Tue, 12 Feb 2019 07:17:17 -0500 Received: from localhost (unknown [122.167.101.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 05B2E20842; Tue, 12 Feb 2019 12:17:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549973836; bh=v3Aa+BNDbmRQo4KNNK+wAyvdBSf0wWM03YRS4gFFGa8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kHSDJxD/N/DKeMi4fMfy7f9zhythlTcy0ZvUN/5jBGFVZ0n/0bUls4jBypA+vo6RA +c2f/eQkI3c22RyLwy7A0vmDJFgf1unzWpU3jhExgsINc8DoI0R4qdBEB4p/ykULR8 U9gob5C5kqohQ8GqDzLAKLfX0sW1oxcuDjOLF1HA= Date: Tue, 12 Feb 2019 17:47:07 +0530 From: Vinod Koul To: Peter Ujfalusi Cc: David S Miller , Roger Quadros , netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, Niklas Cassel , Bjorn Andersson , Andrew Lunn , Florian Fainelli , "Nori, Sekhar" Subject: Re: [v3,4/5] net: phy: at803x: Disable phy delay for RGMII mode Message-ID: <20190212121707.GA4296@vkoul-mobl> References: <20190121091318.20079-5-vkoul@kernel.org> <147151c4-d162-4ebe-189a-564492d84d18@ti.com> <20190212113114.GZ4296@vkoul-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190212113114.GZ4296@vkoul-mobl> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi again, On 12-02-19, 17:01, Vinod Koul wrote: > Hi Peter, > > On 12-02-19, 12:55, Peter Ujfalusi wrote: > > Vinod, > > > > On 21/01/2019 11.13, Vinod Koul wrote: > > > For RGMII mode, phy delay should be disabled. Add this case along > > > with disable delay routines. > > > > In next-20190211 I need to revert this patch to get cpsw networking to > > work on am335x-evmsk. The board uses AR8031_AL1A PHY, which is handled > > by the phy/at803x.c > > I see that DTS specifies that you are using phy-mode = "rgmii-txid". > RGMII mode implies that we should not have any delay in the > phy, so this patch does the right thing. > > In the previous version of the patch I did propose to add a DT entry so > that current users who are wrongly using this would not be impacted but > the suggestion was to get them fixed. > > So in you case do you need rgmii-txd mode if so why should the delay be > enabled for this? We can add a patch that enabled delay for your > controller but that cant be rgmii mode. Relooking at this again and seeing the mode definitions in Documentation/devicetree/bindings/net/ethernet.txt, I think I have got it wrong.. (thanks to Niklas for discussion) So in case of rgmii mode delay should be disabled and in case of rgmii-id/rxid/txid it should be enabled. I will send a patch to address this shortly, please do test. Thanks -- ~Vinod