From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDAEDC282C4 for ; Tue, 12 Feb 2019 13:11:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93AA3214DA for ; Tue, 12 Feb 2019 13:11:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="eeko0w33" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728626AbfBLNLT (ORCPT ); Tue, 12 Feb 2019 08:11:19 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:48348 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727312AbfBLNLT (ORCPT ); Tue, 12 Feb 2019 08:11:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=yM0UcnBY+r7zhMVXBeygvBwoIAjRyHXOghJhIQt8Zfs=; b=eeko0w33TaExN0eotfpBLPLA6z HmhTaeVrEqdVjh1ND7gTrzaelJm9OehCB52nd4yYgydmG/hWqKwO98KgWM3Sudw0DZP6Afe8clQHg TBvL77U7uByB3kdL9VSVjIMhIE6VOpedDgpvjOfGpPKosCbtqBodsmUMx9020OIl/LHo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gtXqF-0002Ot-Va; Tue, 12 Feb 2019 14:11:15 +0100 Date: Tue, 12 Feb 2019 14:11:15 +0100 From: Andrew Lunn To: "Kiyanovski, Arthur" Cc: Moritz Fischer , "David S. Miller" , "netdev@vger.kernel.org" , "Woodhouse, David" , "Machulsky, Zorik" , "Matushevsky, Alexander" , "Bshara, Saeed" , "Wilson, Matt" , "Liguori, Anthony" , "Bshara, Nafea" , "Tzalik, Guy" , "Belgazal, Netanel" , "Saidi, Ali" Subject: Re: [PATCH V1 net 2/2] net: ena: update driver version from 2.0.2 to 2.0.3 Message-ID: <20190212131115.GB7527@lunn.ch> References: <1549905464-13758-1-git-send-email-akiyano@amazon.com> <1549905464-13758-3-git-send-email-akiyano@amazon.com> <55dcaee1242649e2a4d8984f120844ae@EX13D22EUA004.ant.amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55dcaee1242649e2a4d8984f120844ae@EX13D22EUA004.ant.amazon.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 12, 2019 at 11:42:31AM +0000, Kiyanovski, Arthur wrote: > Hi Moritz, > > > -----Original Message----- > > From: Moritz Fischer > > Subject: Re: [PATCH V1 net 2/2] net: ena: update driver version from 2.0.2 to > > 2.0.3 > > > > Hi Arthur, > > > > On Mon, Feb 11, 2019 at 9:19 AM wrote: > > > > > > From: Arthur Kiyanovski > > > > > > Update driver version due to bug fix. > > > > Wouldn't you want to do this atomically with the actual fix in one commit? > > > > Thanks, > > Moritz > > Thanks for the feedback. > I don't want to add the version to the fix. > Version 2.0.3 includes all of its content that came before this fix, including features. > Fixes are cherry-picked to older driver versions automatically using the "Fixes:" directive. > If I add the version change to the fix, older driver versions that get this fix will become version 2.0.3, which is incorrect feature-wise. Hi Arthur I think this points out how useless the version string it, and why many drivers don't use it. Andrew