From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77B80C282CE for ; Tue, 12 Feb 2019 16:30:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4507320842 for ; Tue, 12 Feb 2019 16:30:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="tFieWkMN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730744AbfBLQaC (ORCPT ); Tue, 12 Feb 2019 11:30:02 -0500 Received: from mail-eopbgr10041.outbound.protection.outlook.com ([40.107.1.41]:30784 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731078AbfBLQaB (ORCPT ); Tue, 12 Feb 2019 11:30:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=msJc5xXIsumfssVFQ0JfFHoRvOo97IqU5UZ3wzY1+gk=; b=tFieWkMNvmpxo2pmYkJTviLXi3o6F0pDFCR+Fe6jTWrNp21j8sk8hrA+8AqyNM+qITteOSRtL+w8Apv0QOOpoiDFj/cevHAS6tXiYMFDCAyBJy+4gd0b3P7MKK1vrWPZCCY0LRoAft6v39PNTXDwDOsoA8ICxKCw4P61C5KnwDA= Received: from AM6PR05MB5240.eurprd05.prod.outlook.com (20.177.196.214) by AM6PR05MB6597.eurprd05.prod.outlook.com (20.179.2.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1601.19; Tue, 12 Feb 2019 16:29:53 +0000 Received: from AM6PR05MB5240.eurprd05.prod.outlook.com ([fe80::3542:889c:3a85:3866]) by AM6PR05MB5240.eurprd05.prod.outlook.com ([fe80::3542:889c:3a85:3866%5]) with mapi id 15.20.1601.023; Tue, 12 Feb 2019 16:29:52 +0000 From: Ido Schimmel To: "netdev@vger.kernel.org" CC: "davem@davemloft.net" , Jiri Pirko , Nir Dotan , mlxsw , Ido Schimmel Subject: [PATCH net-next 2/4] mlxsw: spectrum_router: Drop unnecessary WARN_ON_ONCE() Thread-Topic: [PATCH net-next 2/4] mlxsw: spectrum_router: Drop unnecessary WARN_ON_ONCE() Thread-Index: AQHUwvAul5wvl5YJBE2Lo0lo0Gtmeg== Date: Tue, 12 Feb 2019 16:29:52 +0000 Message-ID: <20190212162924.29777-3-idosch@mellanox.com> References: <20190212162924.29777-1-idosch@mellanox.com> In-Reply-To: <20190212162924.29777-1-idosch@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0277.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::25) To AM6PR05MB5240.eurprd05.prod.outlook.com (2603:10a6:20b:64::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.20.1 x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM6PR05MB6597;6:ZTJgGEd1g1YqYFUxiQ43m7yIwqz1JqJBU6wc0ZXGme3pQlagxxhoQtl8dRdj99+qHOmvktx4pshi7MMtegBthdejKFPruq4ZC7fky4v/JxBaimJ9SI9JuXkGQBDqlwS25OFF6EyhVO/8x6XdvaobMj51g0y3JfnCrASMXhoJDM5z6rIyDYhz1A/dEbKI0cSq7CN4Ls1hiTN7nsZuxMqZGXHYqwfxVsEUdSf8kibDDHk8AlcKXUzWRMUDxYmIwuvQMx/ARklBvkG1kExZnwXm7mcT/ARDdcr3AscmUebQpcIYW6sohcfaHDk2mUkoU6GQnhYEUO3iZlSQ9v5rSL/93EzcNN1TLcTz2ncAEhP1PQlM04jgTkyS0qzKvMRBX80sNieSYMsu8r7iFvnR5K3ByawSVNu5cHADyCkQ+iJlWn/UA5+VYkn/ghfBtmnYKZdWnicudkk37Z1jwigEeOnEBg==;5:9/99Ny4cvd0t+T4w7+Z3b2fIPoxm7umxLv0x5zSlT2jUnXAjBuWMuZ7iewVxo55Y0fClhUS6W6jcYSjFGUihYKmeZovIRFkhgzXgwIPApafq/W9QwwTuBxeHMXnNru9LzEX1Ah4L8fTgHuyw3As2NP3SBfP8ydyDTq9dEIKf7FMvuptCUTW3VeopLxIdCnndCxZYGW6j8e6Vye0YYS4+Ag==;7:3O5A/oZVeeqjDp8T6Ic/9kxnuEZM6iXsreTsmBY+rJg0aXRsc8Cti9O1jj0NLAiDiqjNZW5ZjknXPcJ826FM3wHgVzMdUrYI8r+I0XT7W2pUfGFw2wbfv3uQhY8CGg2DjaSHgKtiiV6umqfZBUQsnQ== x-ms-office365-filtering-correlation-id: 01fd35aa-e9b4-41a4-46e0-08d6910750b4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(7193020);SRVR:AM6PR05MB6597; x-ms-traffictypediagnostic: AM6PR05MB6597: x-microsoft-antispam-prvs: x-forefront-prvs: 0946DC87A1 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(346002)(376002)(136003)(39860400002)(366004)(396003)(189003)(52314003)(199004)(478600001)(2351001)(36756003)(14454004)(6506007)(386003)(76176011)(99286004)(4744005)(71190400001)(14444005)(71200400001)(256004)(7736002)(97736004)(2906002)(305945005)(316002)(8676002)(54906003)(81156014)(8936002)(1730700003)(81166006)(6436002)(107886003)(50226002)(6116002)(53936002)(3846002)(25786009)(5640700003)(6486002)(6916009)(446003)(86362001)(6512007)(2616005)(4326008)(476003)(486006)(105586002)(106356001)(2501003)(68736007)(52116002)(186003)(66066001)(26005)(102836004)(11346002)(1076003)(66574012);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR05MB6597;H:AM6PR05MB5240.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: NcsIo9fWCs0x+yITt7QDxcBDpiAqvuQddP47LGKV9SDSJ9C3Iyd9RnbTg0xjanbl7TxffeYJciPwCNZAk3UOReuNMczyu5PMKMOE7ZFUHJdHO01Cn1pVbqC3jeJPFpj85AD7/37YwUMBkitX5/JXUWkpivMq+X8UaxeqxDxFQZAYhx1tgsElCl8b/RhiUT6upd3c9fPNVnRASuBGoEOIFkA4m8ivdQcjDAdPE7H6+Bx7nSC3bkZDJUmp1sB3kyiEOCc2/xJk8BtT8Bxk+5fA/Yzjq8B42PidbNdFK2xly66PNtIZ4/VPoL24D12pMFEQ+PcUhAMqpryYEAVSlA4OsIAJfHQ6BmoxypDGw0BXaUUmfjGUkkP5qp7KQIWWmFJDJHuDXrL8rhtK4QXuGY2xld36He+rYMTJ+g+vmXe+dNo= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 01fd35aa-e9b4-41a4-46e0-08d6910750b4 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Feb 2019 16:29:51.5338 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB6597 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In case the register access failed an error would be logged anyway, so we can drop the warning. Signed-off-by: Ido Schimmel Acked-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/driver= s/net/ethernet/mellanox/mlxsw/spectrum_router.c index 818040ce4d68..52fed8c7bf1e 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c @@ -6142,7 +6142,7 @@ static int mlxsw_sp_router_rif_disable(struct mlxsw_s= p *mlxsw_sp, u16 rif) =20 mlxsw_reg_ritr_rif_pack(ritr_pl, rif); err =3D mlxsw_reg_query(mlxsw_sp->core, MLXSW_REG(ritr), ritr_pl); - if (WARN_ON_ONCE(err)) + if (err) return err; =20 mlxsw_reg_ritr_enable_set(ritr_pl, false); --=20 2.20.1