From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F2C3C282C4 for ; Tue, 12 Feb 2019 18:19:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FFFB222C0 for ; Tue, 12 Feb 2019 18:19:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729097AbfBLSTY (ORCPT ); Tue, 12 Feb 2019 13:19:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58248 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726685AbfBLSTY (ORCPT ); Tue, 12 Feb 2019 13:19:24 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7A5ADA428D; Tue, 12 Feb 2019 18:19:23 +0000 (UTC) Received: from carbon (ovpn-200-42.brq.redhat.com [10.40.200.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1AD1D5E25F; Tue, 12 Feb 2019 18:19:18 +0000 (UTC) Date: Tue, 12 Feb 2019 19:19:17 +0100 From: Jesper Dangaard Brouer To: Florian Fainelli Cc: netdev@vger.kernel.org, linux-mm@kvack.org, Toke =?UTF-8?B?SMO4aWxh?= =?UTF-8?B?bmQtSsO4cmdlbnNlbg==?= , Ilias Apalodimas , willy@infradead.org, Saeed Mahameed , Alexander Duyck , Andrew Morton , mgorman@techsingularity.net, "David S. Miller" , Tariq Toukan , brouer@redhat.com Subject: Re: [net-next PATCH V2 1/3] mm: add dma_addr_t to struct page Message-ID: <20190212191917.2ef91a88@carbon> In-Reply-To: References: <154998290571.8783.11827147914798438839.stgit@firesoul> <154998294324.8783.9045146111677125556.stgit@firesoul> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 12 Feb 2019 18:19:24 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 12 Feb 2019 10:05:39 -0800 Florian Fainelli wrote: > On 2/12/19 6:49 AM, Jesper Dangaard Brouer wrote: > > The page_pool API is using page->private to store DMA addresses. > > As pointed out by David Miller we can't use that on 32-bit architectures > > with 64-bit DMA > > > > This patch adds a new dma_addr_t struct to allow storing DMA addresses > > > > Signed-off-by: Jesper Dangaard Brouer > > Signed-off-by: Ilias Apalodimas > > Acked-by: Andrew Morton > > --- > > include/linux/mm_types.h | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > > index 2c471a2c43fa..581737bd0878 100644 > > --- a/include/linux/mm_types.h > > +++ b/include/linux/mm_types.h > > @@ -95,6 +95,13 @@ struct page { > > */ > > unsigned long private; > > }; > > + struct { /* page_pool used by netstack */ > > + /** > > + * @dma_addr: page_pool requires a 64-bit value even on > > + * 32-bit architectures. > > + */ > > Nit: might require? dma_addr_t, as you mention in the commit may have a > different size based on CONFIG_ARCH_DMA_ADDR_T_64BIT. So you want me to change the comment to be: /** * @dma_addr: might require a 64-bit value even on * 32-bit architectures. */ Correctly understood? -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer