From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E905C282C4 for ; Tue, 12 Feb 2019 22:27:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E232222C9 for ; Tue, 12 Feb 2019 22:27:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="PwAE5OA1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730831AbfBLW1N (ORCPT ); Tue, 12 Feb 2019 17:27:13 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:46707 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727722AbfBLW1J (ORCPT ); Tue, 12 Feb 2019 17:27:09 -0500 Received: by mail-pl1-f196.google.com with SMTP id o6so125431pls.13 for ; Tue, 12 Feb 2019 14:27:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Of6nu0ElKJxqUsS3Jgurrl+J3IwjO5rYheAwWjauzcc=; b=PwAE5OA1GYu/yz38Cx6DXAaReNmFe/azgoHhr/F/fL+uVGjTEZl0gbtMYv/vvXjGwM VJvM953KXmn7GcO4mIlY/AboPu4oVDbBpfDriq9KWgJeEam8Vuh2JhXc3dN3ph6fODLq EaxAjXkVxPjADPNOidIGwcOI01z+H/bAudyOPtFvRX5Rz/rFc2uy5cWNjefB+PlOm85q m9lUr3WdyWl4Wm00XhSepIlxMcAG3la0bIlF9lL9Sr7Bu/5W0lI8swwoFmw33qDKeEZj ITQsZfy6D8h3FJck328oECgAAn8VbVmCSNtyAbd/mhRG8FKkfyUyiNcfFmi731ZnJwqC CP6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Of6nu0ElKJxqUsS3Jgurrl+J3IwjO5rYheAwWjauzcc=; b=bK8hBc23/XW+kADtJRETx/IkTRvYr7/lK1G4E94W5a6eH1MVuxOdUL5E0weOWEEgMp D8y4CQAQlPrLzcjmMvzsK2WjBIsv5/EIgCbSSEZzrP8B1usJ7bE4EZa2Rm9/oK3MKI4D XiEdnslgLZLbu/s6suSmuJ6h/T3gwV8wxGIlzZOMyBpB87aOZ4IaFMNojSncC5dW55iQ DZXBzfVae0Hk01dA2K025HppLMUNK7QPVAkmkPNI0NWrpuS8eu0Z/idb2hHqzmPl/d3J 029ovZsrJgVhTrXoDrcOWnkvLQGLna3WyrCZN7WKoVLTKu9ACHO3189ZboP5ewC0RJgc OdNQ== X-Gm-Message-State: AHQUAua5TGcFFFfa6gUSjyJ219AeCi9kOnG9XYgnkP1Bj7pxX+joRkDx p7N53en+ahjKSulgjM88dHcQjw== X-Google-Smtp-Source: AHgI3IZBJe3cnWsFpXRbQAu/2K7tsjvHAPUo+gnkTgkXJs3itE5VARCUOZ2UTMlBZXfx+YQUzgXLCQ== X-Received: by 2002:a17:902:be0f:: with SMTP id r15mr6151245pls.97.1550010428971; Tue, 12 Feb 2019 14:27:08 -0800 (PST) Received: from ziepe.ca (S010614cc2056d97f.ed.shawcable.net. [174.3.196.123]) by smtp.gmail.com with ESMTPSA id n73sm20589707pfj.148.2019.02.12.14.27.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Feb 2019 14:27:08 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1gtgWB-0003Zi-Kx; Tue, 12 Feb 2019 15:27:07 -0700 Date: Tue, 12 Feb 2019 15:27:07 -0700 From: Jason Gunthorpe To: Shiraz Saleem Cc: dledford@redhat.com, davem@davemloft.net, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, mustafa.ismail@intel.com, jeffrey.t.kirsher@intel.com Subject: Re: [RFC 12/19] RDMA/irdma: Implement device supported verb APIs Message-ID: <20190212222707.GU24692@ziepe.ca> References: <20190212214402.23284-1-shiraz.saleem@intel.com> <20190212214402.23284-13-shiraz.saleem@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190212214402.23284-13-shiraz.saleem@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 12, 2019 at 03:43:55PM -0600, Shiraz Saleem wrote: > +/** > + * irdma_disassociate_ucontext - Disassociate user context > + * @context: ib user context > + */ > +static void irdma_disassociate_ucontext(struct ib_ucontext *context) > +{ > + struct irdma_ucontext *ucontext = to_ucontext(context); > + > + struct irdma_vma_data *vma_data, *n; > + struct vm_area_struct *vma; > + > + irdma_dev_info(&ucontext->iwdev->rf->sc_dev, "called\n"); > + mutex_lock(&ucontext->vma_list_mutex); > + list_for_each_entry_safe(vma_data, n, &ucontext->vma_list, list) { > + vma = vma_data->vma; > + zap_vma_ptes(vma, vma->vm_start, PAGE_SIZE); > + > + vma->vm_flags &= ~(VM_SHARED | VM_MAYSHARE); > + vma->vm_ops = NULL; > + list_del(&vma_data->list); > + kfree(vma_data); > + } > + mutex_unlock(&ucontext->vma_list_mutex); > +} You need to study all the changes that have been done in the core code and make sure this driver is using all the latest stuff, I do not want to review a driver and find it is full of obsolete APIs like this above. Jason