From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B1D9C282C4 for ; Tue, 12 Feb 2019 23:05:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF964222C7 for ; Tue, 12 Feb 2019 23:05:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="oTVvbM/G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730907AbfBLXFK (ORCPT ); Tue, 12 Feb 2019 18:05:10 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:39904 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730788AbfBLXFK (ORCPT ); Tue, 12 Feb 2019 18:05:10 -0500 Received: by mail-pf1-f195.google.com with SMTP id f132so181986pfa.6 for ; Tue, 12 Feb 2019 15:05:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=yjSrsqaN0O24sjMqfMzSGi3mFIBcjB+skzjKYHKILAA=; b=oTVvbM/G9cs+O6qKlOXCMSBwx8hYhUK56dMjpRmyqDjfGV6v4iVq9UcHrXsjc7l9ax N9p3ONjA8NH+T6VjrQhkzVyFmyoPLFHzXSg14R0Tm8gMj0momfvjmk7876JsTf7l8Arp ahspzGe01kSl28zfTgSed3JZR/hIMLOc+wqdLFR2g7fBiHKwE93r0pKKTHqLE/huFUVd yVjUDGepAFw3np7x1p4JrbmV0elfbHvYaBK4HGj4+8v/1u3bQb6j6g2euZ0+TnnWpgs0 J2MC6WD/nei466U5fsiDVnBUz3xTs4Az/FaEgsePXen4z53W64eE9x4qORd+/my/4Q/M 2bFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yjSrsqaN0O24sjMqfMzSGi3mFIBcjB+skzjKYHKILAA=; b=L/Tg69mKVyYuwCJV7iyeTSZ/cv2VwF3n8jlnLb+Opa3PibKP1JS3z9WkTv61CcvLmI Mv7/13fjjCy/+jvu6Od7lX4gKLF15xYxWVv/5AR2XDIMdQJbVLXE+hFBmR+mmJqLVvK8 0lgWJKbXKmT2OTRx33WWeyBtnyEKqUe1aiMoAypCGSxhqk+NDnLPn6zs8vslfw8j6l9b cRmRKah3ieBzsLE5U96qhCk4xkvF9Lp6n9dO1qQFLDDd7IstOLuuGYKdNL/3TgR29zyK wYJUu97EPwF4Hfvwilzdx6rQPoolnE53YQaUtng74iJ4QpMdmJGFgc4WZlxyX+1n22y/ Zw8A== X-Gm-Message-State: AHQUAuZj+IMFd/sFldJMye5pDQSN+QZX8vMh0Uqtvp/AR8J6kE5CSbOo hPIwnEuiEzB19lXG6GH5kPHdnw== X-Google-Smtp-Source: AHgI3IZZdwFF9ruHoFjucell5G347iDJGww+Z7D/ZhyezB8E2g1apmKZMjV52YGnrFK4V/LmpJQJPw== X-Received: by 2002:a63:7c41:: with SMTP id l1mr5810524pgn.45.1550012709468; Tue, 12 Feb 2019 15:05:09 -0800 (PST) Received: from ziepe.ca (S010614cc2056d97f.ed.shawcable.net. [174.3.196.123]) by smtp.gmail.com with ESMTPSA id e16sm17399416pfn.46.2019.02.12.15.05.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Feb 2019 15:05:08 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1gth6y-0003u2-1E; Tue, 12 Feb 2019 16:05:08 -0700 Date: Tue, 12 Feb 2019 16:05:08 -0700 From: Jason Gunthorpe To: Shiraz Saleem Cc: dledford@redhat.com, davem@davemloft.net, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, mustafa.ismail@intel.com, jeffrey.t.kirsher@intel.com Subject: Re: [RFC 17/19] RDMA/irdma: Add ABI definitions Message-ID: <20190212230508.GV24692@ziepe.ca> References: <20190212214402.23284-1-shiraz.saleem@intel.com> <20190212214402.23284-18-shiraz.saleem@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190212214402.23284-18-shiraz.saleem@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 12, 2019 at 03:44:00PM -0600, Shiraz Saleem wrote: > +struct irdma_create_cq_req { > + __aligned_u64 user_cq_buf; > + __aligned_u64 user_shadow_area; > +}; This is the right way to use u64 in uapi headers > + > +struct irdma_create_qp_req { > + __u64 user_wqe_bufs; > + __u64 user_compl_ctx; > +}; and this is wrong.. See my prior email. Jason