From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CE85C43381 for ; Thu, 14 Feb 2019 05:05:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D219E222C9 for ; Thu, 14 Feb 2019 05:05:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389841AbfBNFF4 (ORCPT ); Thu, 14 Feb 2019 00:05:56 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:48602 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726214AbfBNFF4 (ORCPT ); Thu, 14 Feb 2019 00:05:56 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C74CC14CF61E4; Wed, 13 Feb 2019 21:05:55 -0800 (PST) Date: Wed, 13 Feb 2019 21:05:55 -0800 (PST) Message-Id: <20190213.210555.956154260555088522.davem@davemloft.net> To: edumazet@google.com Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com Subject: Re: [PATCH net] net: fix possible overflow in __sk_mem_raise_allocated() From: David Miller In-Reply-To: <20190212202627.184863-1-edumazet@google.com> References: <20190212202627.184863-1-edumazet@google.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 13 Feb 2019 21:05:55 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Eric Dumazet Date: Tue, 12 Feb 2019 12:26:27 -0800 > With many active TCP sockets, fat TCP sockets could fool > __sk_mem_raise_allocated() thanks to an overflow. > > They would increase their share of the memory, instead > of decreasing it. > > Signed-off-by: Eric Dumazet Applied, thanks Eric.