From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60697C43381 for ; Thu, 14 Feb 2019 05:07:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 33EEA222C9 for ; Thu, 14 Feb 2019 05:07:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393957AbfBNFHG (ORCPT ); Thu, 14 Feb 2019 00:07:06 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:48614 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725781AbfBNFHF (ORCPT ); Thu, 14 Feb 2019 00:07:05 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D700314CF61D1; Wed, 13 Feb 2019 21:07:04 -0800 (PST) Date: Wed, 13 Feb 2019 21:07:04 -0800 (PST) Message-Id: <20190213.210704.1651652558023166187.davem@davemloft.net> To: vladbu@mellanox.com Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, pablo@netfilter.org Subject: Re: [PATCH net-next] net: sched: flower: only return error from hw offload if skip_sw From: David Miller In-Reply-To: <20190212213906.9368-1-vladbu@mellanox.com> References: <20190212213906.9368-1-vladbu@mellanox.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 13 Feb 2019 21:07:05 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vlad Buslov Date: Tue, 12 Feb 2019 23:39:06 +0200 > Recently introduced tc_setup_flow_action() can fail when parsing tcf_exts > on some unsupported action commands. However, this should not affect the > case when user did not explicitly request hw offload by setting skip_sw > flag. Modify tc_setup_flow_action() callers to only propagate the error if > skip_sw flag is set for filter that is being offloaded, and set extack > error message in that case. > > Signed-off-by: Vlad Buslov > Fixes: 3a7b68617de7 ("cls_api: add translator to flow_action representation") Applied, thanks Vlad.