Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: vishal@chelsio.com
Cc: netdev@vger.kernel.org, nirranjan@chelsio.com,
	indranil@chelsio.com, dt@chelsio.com
Subject: Re: [PATCH net-next 1/2] cxgb4/cxgb4vf: Add support for SGE doorbell queue timer
Date: Wed, 13 Feb 2019 22:10:43 -0800 (PST)	[thread overview]
Message-ID: <20190213.221043.122004348292926904.davem@davemloft.net> (raw)
In-Reply-To: <1550034844-10850-2-git-send-email-vishal@chelsio.com>

From: Vishal Kulkarni <vishal@chelsio.com>
Date: Wed, 13 Feb 2019 10:44:03 +0530

> T6 introduced a Timer Mechanism in SGE called the
> SGE Doorbell Queue Timer. With this we can now configure
> TX Queues to get CIDX Updates when:
> 
>     Time(CIDX == PIDX) >= Timer
> 
> Previously we rely on TX Queue Status Page updates by hardware
> for DMA completions. This will make Hardware/Firmware actually
> deliver the CIDX Updates as Ingress Queue messages with
> commensurate Interrupts.
> 
> So we now have a new RX Path component for processing CIDX Updates
> and reclaiming TX Descriptors faster.
> 
> Original work by: Casey Leedom <leedom@chelsio.com>
> 
> Signed-off-by: Vishal Kulkarni <vishal@chelsio.com>

Can you at least fix the reverse christmas tree situation for the functions
where you add or remove local variables?

Thank you.

  reply	other threads:[~2019-02-14  6:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-13  5:14 [PATCH net-next 0/2] cxgb4/cxgb4vf:Support for SGE doorbell queue timer Vishal Kulkarni
2019-02-13  5:14 ` [PATCH net-next 1/2] cxgb4/cxgb4vf: Add support " Vishal Kulkarni
2019-02-14  6:10   ` David Miller [this message]
2019-02-13  5:14 ` [PATCH net-next 2/2] cxgb4: Add capability to get/set SGE Doorbell Queue Timer Tick Vishal Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190213.221043.122004348292926904.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dt@chelsio.com \
    --cc=indranil@chelsio.com \
    --cc=netdev@vger.kernel.org \
    --cc=nirranjan@chelsio.com \
    --cc=vishal@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox