From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84899C43381 for ; Thu, 14 Feb 2019 06:13:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B771222A1 for ; Thu, 14 Feb 2019 06:13:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405725AbfBNGNu (ORCPT ); Thu, 14 Feb 2019 01:13:50 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:49092 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726407AbfBNGNt (ORCPT ); Thu, 14 Feb 2019 01:13:49 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id EF47714CF825C; Wed, 13 Feb 2019 22:13:48 -0800 (PST) Date: Wed, 13 Feb 2019 22:13:48 -0800 (PST) Message-Id: <20190213.221348.256498581984900019.davem@davemloft.net> To: dan.carpenter@oracle.com Cc: jiri@mellanox.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 3/3 net-next] test_objagg: Uninitialized variable in error handling From: David Miller In-Reply-To: <20190213085931.GD14113@kadam> References: <20190213085650.GB14113@kadam> <20190213085931.GD14113@kadam> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 13 Feb 2019 22:13:49 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Dan Carpenter Date: Wed, 13 Feb 2019 11:59:31 +0300 > We need to set the error message on this path otherwise some of the > callers, such as test_hints_case(), print from an uninitialized pointer. > > We had a similar bug earlier and set "errmsg" to NULL in the caller, > test_delta_action_item(). That code is no longer required so I have > removed it. > > Fixes: 9069a3817d82 ("lib: objagg: implement optimization hints assembly and use hints for object creation") > Signed-off-by: Dan Carpenter Applied.