From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46B17C43381 for ; Thu, 14 Feb 2019 06:33:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 11F58222A1 for ; Thu, 14 Feb 2019 06:33:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392481AbfBNGde (ORCPT ); Thu, 14 Feb 2019 01:33:34 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:49228 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726405AbfBNGde (ORCPT ); Thu, 14 Feb 2019 01:33:34 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D152914CF8EDF; Wed, 13 Feb 2019 22:33:33 -0800 (PST) Date: Wed, 13 Feb 2019 22:33:33 -0800 (PST) Message-Id: <20190213.223333.291700524202829827.davem@davemloft.net> To: idosch@mellanox.com Cc: netdev@vger.kernel.org, jiri@mellanox.com, andrew@lunn.ch, mlxsw@mellanox.com Subject: Re: [PATCH net-next 00/12] mlxsw: hwmon and thermal extensions From: David Miller In-Reply-To: <20190213112814.32334-1-idosch@mellanox.com> References: <20190213112814.32334-1-idosch@mellanox.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 13 Feb 2019 22:33:34 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ido Schimmel Date: Wed, 13 Feb 2019 11:28:43 +0000 > Vadim says: > > This patchset contains various improvements to hwmon and thermal code in > mlxsw. The most significant improvement is the ability to read modules' > temperature attributes (input, fault, critical and emergency thresholds) > as well as fans' fault indication. These new attributes will improve the > ability to monitor the system. > > Patches #1-#4 add the necessary device registers and APIs to read > modules' temperature attributes and fans' fault indication. > > Patches #5-#8 perform small improvements in hwmon and thermal code such > as using a more indicative name for cooling devices. > > Patch #9 exposes fans' fault indication via hwmon. > > Patch #10 exposes modules' temperature attributes via hwmon. > > Patch #11 adds an hwmon label to modules' temperature sensor. This helps > to parse the output of utilities such as "sensors". > > Patch #12 allows to bind an external cooling device ("mlxreg-fan") to > mlxsw thermal zone. This will allow the mlxsw thermal zone to change the > cooling level of cooling devices not programmed via switch registers. I'm going to apply this to net-next as-is. Please address the HWMON stuff as a follow-up. Thank you.