From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CD27C282C4 for ; Wed, 13 Feb 2019 02:46:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 03B4021934 for ; Wed, 13 Feb 2019 02:46:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550025961; bh=zVM5TYnhVQuVmWTff6iNhQtK0AZpj+0yhJWM90uHM8U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Ga6tXBFuO8LmRFhHlL5Fko2lhwsRbi8/L571f0uKIccNEqzT7mpQGVlTwzM8n/Sae yrsHrFGRVItQrL++hRtdTIU/VIsM1mH8sagnZM2OwXl4QQxvk4W0WjFtz4BeEpuVVv SieRvwHZ6K398xrKEUm8NzIrGKxTH39vAh4DCWLo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389663AbfBMCpw (ORCPT ); Tue, 12 Feb 2019 21:45:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:44628 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389101AbfBMCkv (ORCPT ); Tue, 12 Feb 2019 21:40:51 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 09F722175B; Wed, 13 Feb 2019 02:40:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550025650; bh=zVM5TYnhVQuVmWTff6iNhQtK0AZpj+0yhJWM90uHM8U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i9KVrmzmihF9qL0SLxqkA7/Zk/0F43Emp9Fr+DB57Zm8we1XqXghGSYwuR2wIMlKL H4xz5+1bH6Ij6ZV7W3JwJBqsGsZUSfj0lGZZiEpyEL1Vk7jTQLvjY3IWgehQffPvZn Gk+iWJ/+M8OGFKfCRmm+5zD8gegbdP3w9WSVYRAc= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Denis Bolotin , Ariel Elior , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 09/21] qed: Fix qed_ll2_post_rx_buffer_notify_fw() by adding a write memory barrier Date: Tue, 12 Feb 2019 21:40:28 -0500 Message-Id: <20190213024040.21740-9-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190213024040.21740-1-sashal@kernel.org> References: <20190213024040.21740-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Denis Bolotin [ Upstream commit 46721c3d9e273aea880e9ff835b0e1271e1cd2fb ] Make sure chain element is updated before ringing the doorbell. Signed-off-by: Denis Bolotin Signed-off-by: Ariel Elior Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/qlogic/qed/qed_ll2.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drivers/net/ethernet/qlogic/qed/qed_ll2.c index a3360cbdb30b..5b968e6a0a7f 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c +++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c @@ -1013,6 +1013,10 @@ static void qed_ll2_post_rx_buffer_notify_fw(struct qed_hwfn *p_hwfn, cq_prod = qed_chain_get_prod_idx(&p_rx->rcq_chain); rx_prod.bd_prod = cpu_to_le16(bd_prod); rx_prod.cqe_prod = cpu_to_le16(cq_prod); + + /* Make sure chain element is updated before ringing the doorbell */ + dma_wmb(); + DIRECT_REG_WR(p_rx->set_prod_addr, *((u32 *)&rx_prod)); } -- 2.19.1