From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36DE0C282C2 for ; Wed, 13 Feb 2019 08:57:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECD82222BB for ; Wed, 13 Feb 2019 08:57:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="F8YJkIYM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390902AbfBMI5F (ORCPT ); Wed, 13 Feb 2019 03:57:05 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:40446 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388056AbfBMI5F (ORCPT ); Wed, 13 Feb 2019 03:57:05 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1D8rxUs106839; Wed, 13 Feb 2019 08:57:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2018-07-02; bh=Egxih18p97lt7LNcyT18JgJYLiJe1EilZUt6+mSFF8Q=; b=F8YJkIYMTWlXDt5x+WRRRPVGSC3xtsDXw0igot1R1mYx7raOn/W/1SJg1xbyWpvaCuJ/ fKHXkBjSVC5KCCzpgnNOM0oxwpz4fXQ16L4rU396a1IFRIgVGE2UAV3C1qlXVEQPM26z ZvqIlN8QpmUYm7/K7hhXC8ywB8M5ZqsboOa+EJyS8XLExeIVGEKVLEQ1wWLdRPMBQto+ DcSOmIwoK+go0MZuRpNk1fCkwI1G4Y6c2loVZXMmHWhxg8tmkPQVqP+tIqmfDyTuktB6 3FT9QxmfdMZzpBCGo/v4T8sOYWs94hpxlL1Gl22lu/Tf7nPz7WOiBomjQdxAb5GDtbfE AQ== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2130.oracle.com with ESMTP id 2qhrekgn97-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Feb 2019 08:57:00 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x1D8uxk1031850 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Feb 2019 08:56:59 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x1D8uwU9025179; Wed, 13 Feb 2019 08:56:59 GMT Received: from kadam (/41.202.241.15) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 13 Feb 2019 08:56:58 +0000 Date: Wed, 13 Feb 2019 11:56:50 +0300 From: Dan Carpenter To: Jiri Pirko Cc: netdev@vger.kernel.org, Ido Schimmel , kernel-janitors@vger.kernel.org Subject: [PATCH 1/3 net-next] lib: objagg: Fix an error code in objagg_hints_get() Message-ID: <20190213085650.GB14113@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9165 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902130066 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org We need to set the error code on this path otherwise we return ERR_PTR(0) which would result in a NULL dereference in the caller. Fixes: 9069a3817d82 ("lib: objagg: implement optimization hints assembly and use hints for object creation") Signed-off-by: Dan Carpenter --- lib/objagg.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/objagg.c b/lib/objagg.c index 781f41c3c47d..d552ec9c60ed 100644 --- a/lib/objagg.c +++ b/lib/objagg.c @@ -968,8 +968,10 @@ struct objagg_hints *objagg_hints_get(struct objagg *objagg, if (err) goto err_fillup_hints; - if (WARN_ON(objagg_hints->node_count != objagg->obj_count)) + if (WARN_ON(objagg_hints->node_count != objagg->obj_count)) { + err = -EINVAL; goto err_node_count_check; + } return objagg_hints; -- 2.17.1