From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 749CEC282C2 for ; Wed, 13 Feb 2019 11:49:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4EE61222B2 for ; Wed, 13 Feb 2019 11:49:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733126AbfBMLt4 (ORCPT ); Wed, 13 Feb 2019 06:49:56 -0500 Received: from a.mx.secunet.com ([62.96.220.36]:36404 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730063AbfBMLt4 (ORCPT ); Wed, 13 Feb 2019 06:49:56 -0500 Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id 011CC20258; Wed, 13 Feb 2019 12:49:55 +0100 (CET) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H-M5ZdQIfzUQ; Wed, 13 Feb 2019 12:49:54 +0100 (CET) Received: from mail-essen-01.secunet.de (mail-essen-01.secunet.de [10.53.40.204]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id A3C7720251; Wed, 13 Feb 2019 12:49:54 +0100 (CET) Received: from gauss2.secunet.de (10.182.7.193) by mail-essen-01.secunet.de (10.53.40.204) with Microsoft SMTP Server id 14.3.435.0; Wed, 13 Feb 2019 12:49:54 +0100 Received: by gauss2.secunet.de (Postfix, from userid 1000) id 3172F318265A; Wed, 13 Feb 2019 12:49:54 +0100 (CET) Date: Wed, 13 Feb 2019 12:49:54 +0100 From: Steffen Klassert To: Willem de Bruijn CC: Network Development , Willem de Bruijn , Paolo Abeni , "Jason A. Donenfeld" Subject: Re: [PATCH RFC v2 2/3] net: Support GRO/GSO fraglist chaining. Message-ID: <20190213114954.GA3087@gauss3.secunet.de> References: <20190128085025.14532-1-steffen.klassert@secunet.com> <20190128085025.14532-3-steffen.klassert@secunet.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-G-Data-MailSecurity-for-Exchange-State: 0 X-G-Data-MailSecurity-for-Exchange-Error: 0 X-G-Data-MailSecurity-for-Exchange-Sender: 23 X-G-Data-MailSecurity-for-Exchange-Server: d65e63f7-5c15-413f-8f63-c0d707471c93 X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 X-G-Data-MailSecurity-for-Exchange-Guid: F77F44E7-B579-4F7B-88CB-5264404B6268 X-G-Data-MailSecurity-for-Exchange-ProcessedOnRouted: True Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jan 28, 2019 at 02:50:34PM -0600, Willem de Bruijn wrote: > On Mon, Jan 28, 2019 at 2:53 AM Steffen Klassert > wrote: > > + > > + if (skb_needs_linearize(skb, features) && > > + __skb_linearize(skb)) { > > + skb->next = NULL; > > + kfree_skb_list(skb->next); > > inverse order Oh yes, apparently. > > also, I would probably deduplicate with the same branch above in a new > err_linearize: block Will do that. Thanks for the review!