From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46A1EC282C2 for ; Wed, 13 Feb 2019 13:25:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 008B3222B1 for ; Wed, 13 Feb 2019 13:25:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="jUPr9pOQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388294AbfBMNZM (ORCPT ); Wed, 13 Feb 2019 08:25:12 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:33187 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730301AbfBMNZL (ORCPT ); Wed, 13 Feb 2019 08:25:11 -0500 Received: by mail-wm1-f68.google.com with SMTP id h22so1888234wmb.0 for ; Wed, 13 Feb 2019 05:25:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=yFe1sJ/hzYw+lkR695VtTHmWDeznpueNiotoo6/Ejoc=; b=jUPr9pOQlqvHq5U9605T8vrNSZ2Y4tdwbC1c9eC6/80SiZvgMYS9WKSQ5Xw7r5iQvx CNHeHsk5hYA20qyfL60aBcbd3D6LJF9HTcjYouqJ4HlPHcR6QxQ14qTYfMtMTnUrOH0z +AJafxC8Zt9WhZxP824BwmEWeJsJ+sn69f2oX9yoiZuLJGSBDJMt0Mabkz0McxCd2IpU DCqEZxTnKaMPkRGNi2UVC9GxnqGNDwhBhFCkH6gAFC1YAGbpJMW9m42tNdSfY7LjKNTI +a+RHwGqMHuIXtNezoqBh5tz42fROP2cy9/GyznizkICqEym+A++6x4roPnxIx+fj1Sx 2GtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yFe1sJ/hzYw+lkR695VtTHmWDeznpueNiotoo6/Ejoc=; b=ch9cU+choQUJfczkdqOmgS/Q91Ffl5HFM5tjgsMEJyvEJFztP1zpM3L/hUgtbs98WF z2Ae24O7oT1MPK+Q+as2oVP0fpVedb3shZ8D7opBBqApYITitaLQ9No+CFuz/e4Iv5RK 39/2giHbynPBC85ZhMGAvIdF84lJ6yA7Vo58o80gBUUS/E0v9Y7CyqnjzE0jyZAUto3k oBgckcfVfhEvStMI/JHTEsKrPqXlGumJpsuw/eo1UjrGPaTFuwg/5BwckVLH8F62SJbI GA2MosnqdNQsUyf5HytRXlGge5npl9bGn8AzbRXCFgsCXECtMT6utb+L6EzPZvnkOO0D 3AsA== X-Gm-Message-State: AHQUAuafTLWqkuMo0ksxkAwu+Djb8wbwU00Hwge5nwKTkcjA8W11Bvht /DpdD7W5JyFat3j898s/ta0Xdw== X-Google-Smtp-Source: AHgI3IaDZbNBZy3pCzTGrPvQdtjsBBW3xCofbY8JMf6ODwr2Knyq/TGF0DCxJs8ocaS7BzLUQqXUDw== X-Received: by 2002:a7b:c7c1:: with SMTP id z1mr292521wmk.77.1550064309364; Wed, 13 Feb 2019 05:25:09 -0800 (PST) Received: from localhost (mail.chocen-mesto.cz. [85.163.43.2]) by smtp.gmail.com with ESMTPSA id x21sm7021650wmi.28.2019.02.13.05.25.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Feb 2019 05:25:08 -0800 (PST) Date: Wed, 13 Feb 2019 14:15:42 +0100 From: Jiri Pirko To: Dan Carpenter Cc: Jiri Pirko , netdev@vger.kernel.org, Ido Schimmel , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/3 net-next] lib: objagg: Fix an error code in objagg_hints_get() Message-ID: <20190213131542.GB2186@nanopsycho> References: <20190213085650.GB14113@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190213085650.GB14113@kadam> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Wed, Feb 13, 2019 at 09:56:50AM CET, dan.carpenter@oracle.com wrote: >We need to set the error code on this path otherwise we return >ERR_PTR(0) which would result in a NULL dereference in the caller. > >Fixes: 9069a3817d82 ("lib: objagg: implement optimization hints assembly and use hints for object creation") >Signed-off-by: Dan Carpenter I have the same patch in my queue. Acked-by: Jiri Pirko