From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 942F1C282C2 for ; Wed, 13 Feb 2019 13:26:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5A4E2222B1 for ; Wed, 13 Feb 2019 13:26:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="Uh8qShRT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390717AbfBMN0Q (ORCPT ); Wed, 13 Feb 2019 08:26:16 -0500 Received: from mail-wm1-f46.google.com ([209.85.128.46]:33899 "EHLO mail-wm1-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388695AbfBMN0Q (ORCPT ); Wed, 13 Feb 2019 08:26:16 -0500 Received: by mail-wm1-f46.google.com with SMTP id y185so1887989wmd.1 for ; Wed, 13 Feb 2019 05:26:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3xXH9SD17ipQMXdp26iQziO8ix0cv1w2IhB4zednBYQ=; b=Uh8qShRTAUhyDUwYEDUZikVFK9xKoKr7F4FpXn4uhkAvsC6niUk+PG/MesMUFCDyhJ bKF/dp4qanz9o0FxQd9aql7iaZnodGSIXdT5Ju0thkMB5nWk5KP1FHd/ELH6QgSt85Nr ACZf7qmE0zw+YbsvR2xv8urTAyyaIFznExSxYs4tUZ19NIBTYhYsE/Sc7l8wqIyBT/t2 bzxo0vPUIucwKspHDiii3u2MZ2kdaZ2dUR/roRFYs33QLpBHUEf+O1ZXwJ7KBjFqDqY1 /UQeoMXIrgLe/ngpDadbqBLoLu2hHBxdhUrb4OERMwFYeoCpmZ8lMHk9jPUPc/cy6gy7 083g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3xXH9SD17ipQMXdp26iQziO8ix0cv1w2IhB4zednBYQ=; b=ZS/X4Gy7ripJNrZILHt5s2ign7cPzf+g3KOVDY9CVwvi4dJlTq1Wfy/zNhLyWwDQK8 8TmFZQT9qpkjJKjgDPKofBXNAqKYiKIjTvw4DCVZ1imzr83Q4yMHw8bea1VquWseWDNs oSP2O/Zo7LkxqdfyocjTt261WAu0uAz57iG/dgr0tq9m8TcIhtGKmoV1ACQKXLBZpRNx L5ydnhz0d/uCX5aIoSV2kYx+gKW5uTjfSH5NvvSJ6x7TqC1bFgD9YCbA3ahWRxXJaSyi pMaC5LL/zzGhR3CCT/5i/CTu7TnFVeT9IYi0DQnoiT8Euy0DL/75P98+yUWrTVaswBsE +6/w== X-Gm-Message-State: AHQUAuZRR0IOgcYypTYEL/kyVDvuaSs5dwYkyncN39RMOYKHj430iIJ7 GX2yIeCPoHJNBK+3vwO78/OCXw== X-Google-Smtp-Source: AHgI3IaEivBN/ysQk/rJPT+zKobzlA0ALsFunYn+QvewOgiP3DRdUju5XmyAT+esFJBu89khiae+LQ== X-Received: by 2002:a1c:2544:: with SMTP id l65mr314027wml.93.1550064374090; Wed, 13 Feb 2019 05:26:14 -0800 (PST) Received: from localhost (mail.chocen-mesto.cz. [85.163.43.2]) by smtp.gmail.com with ESMTPSA id c186sm9869486wmf.34.2019.02.13.05.26.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Feb 2019 05:26:13 -0800 (PST) Date: Wed, 13 Feb 2019 14:16:47 +0100 From: Jiri Pirko To: Dan Carpenter Cc: Jiri Pirko , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 3/3 net-next] test_objagg: Uninitialized variable in error handling Message-ID: <20190213131647.GD2186@nanopsycho> References: <20190213085650.GB14113@kadam> <20190213085931.GD14113@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190213085931.GD14113@kadam> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Wed, Feb 13, 2019 at 09:59:31AM CET, dan.carpenter@oracle.com wrote: >We need to set the error message on this path otherwise some of the >callers, such as test_hints_case(), print from an uninitialized pointer. > >We had a similar bug earlier and set "errmsg" to NULL in the caller, >test_delta_action_item(). That code is no longer required so I have >removed it. > >Fixes: 9069a3817d82 ("lib: objagg: implement optimization hints assembly and use hints for object creation") >Signed-off-by: Dan Carpenter Acked-by: Jiri Pirko