From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44ACEC282C2 for ; Wed, 13 Feb 2019 13:53:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0949F2075D for ; Wed, 13 Feb 2019 13:53:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="T73k+Wdq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388047AbfBMNxg (ORCPT ); Wed, 13 Feb 2019 08:53:36 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:50109 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730214AbfBMNxf (ORCPT ); Wed, 13 Feb 2019 08:53:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3IdGaTEYTSycaMEpBSxNYax1JiECa5wvGWMT01XVquw=; b=T73k+WdqKd4QHDOw6QeAywRIwE pFBQOPedtIhqgXIGjiqwKL7HQJMBj8/jGoz9kfa0kgCwsXhcEoTeNfOJz9z4hizreRWUkW3cnz0Vy JgX5ydfnT4ZPYZThh+/naUSieeT7hLM82Wsxmq+Doq1uSETFGqEVKwBxEVX9mLXnTJPc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gtuyh-0006wp-W2; Wed, 13 Feb 2019 14:53:31 +0100 Date: Wed, 13 Feb 2019 14:53:31 +0100 From: Andrew Lunn To: Ido Schimmel Cc: "netdev@vger.kernel.org" , "davem@davemloft.net" , Jiri Pirko , mlxsw , Vadim Pasternak , Guenter Roeck Subject: Re: [PATCH net-next 09/12] mlxsw: core: Extend hwmon interface with fan fault attribute Message-ID: <20190213135331.GB24589@lunn.ch> References: <20190213112814.32334-1-idosch@mellanox.com> <20190213112814.32334-10-idosch@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190213112814.32334-10-idosch@mellanox.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 13, 2019 at 11:28:53AM +0000, Ido Schimmel wrote: > From: Vadim Pasternak > > Add new fan hwmon attribute for exposing fan faults (fault indication is > read from Fan Out of Range Event Register). > > Signed-off-by: Vadim Pasternak > Reviewed-by: Jiri Pirko > Signed-off-by: Ido Schimmel Hi Ido You should include the HWMON maintainer in the Cc: list. I would not be too surprised if he says to use hwmon_device_register_with_info(). Andrew