From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18373C282C2 for ; Wed, 13 Feb 2019 16:59:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 967F421934 for ; Wed, 13 Feb 2019 16:59:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392811AbfBMQ7v (ORCPT ); Wed, 13 Feb 2019 11:59:51 -0500 Received: from mail.us.es ([193.147.175.20]:58104 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733155AbfBMQ7v (ORCPT ); Wed, 13 Feb 2019 11:59:51 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 0A898F2623 for ; Wed, 13 Feb 2019 17:59:48 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id ED465DA84E for ; Wed, 13 Feb 2019 17:59:47 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id E2A9CDA796; Wed, 13 Feb 2019 17:59:47 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 03A76DA7F4; Wed, 13 Feb 2019 17:59:46 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Wed, 13 Feb 2019 17:59:46 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id D291C4265A2F; Wed, 13 Feb 2019 17:59:45 +0100 (CET) Date: Wed, 13 Feb 2019 17:59:46 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: John Hurley Cc: jiri@mellanox.com, davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [PATCH net-next 1/1] flow_offload: fix block stats Message-ID: <20190213165946.icyby3dsvcxvjbv2@salvia> References: <1550017432-26306-1-git-send-email-john.hurley@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1550017432-26306-1-git-send-email-john.hurley@netronome.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 13, 2019 at 12:23:52AM +0000, John Hurley wrote: > With the introduction of flow_stats_update(), drivers now update the stats > fields of the passed tc_cls_flower_offload struct, rather than call > tcf_exts_stats_update() directly to update the stats of offloaded TC > flower rules. However, if multiple qdiscs are registered to a TC shared > block and a flower rule is applied, then, when getting stats for the rule, > multiple callbacks may be made. > > Take this into consideration by modifying flow_stats_update to gather the > stats from all callbacks. Currently, the values in tc_cls_flower_offload > only account for the last stats callback in the list. > > Fixes: 3b1903ef97c0 ("flow_offload: add statistics retrieval infrastructure and use it") > Signed-off-by: John Hurley > Reviewed-by: Jakub Kicinski Acked-by: Pablo Neira Ayuso