* [PATCH net] selftests: fix timestamping Makefile
@ 2019-02-13 17:09 Deepa Dinamani
2019-02-13 18:17 ` shuah
2019-02-14 17:03 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Deepa Dinamani @ 2019-02-13 17:09 UTC (permalink / raw)
To: shuah; +Cc: willemb, netdev, linux-kselftest
The clean target in the makefile conflicts with the generic
kselftests lib.mk, and fails to properly remove the compiled
test programs.
Remove the redundant rule, the TEST_GEN_FILES will be already
removed by the CLEAN macro in lib.mk.
Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
---
* Changes since v1: as per review comments
tools/testing/selftests/networking/timestamping/Makefile | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tools/testing/selftests/networking/timestamping/Makefile b/tools/testing/selftests/networking/timestamping/Makefile
index 9050eeea5f5f..1de8bd8ccf5d 100644
--- a/tools/testing/selftests/networking/timestamping/Makefile
+++ b/tools/testing/selftests/networking/timestamping/Makefile
@@ -9,6 +9,3 @@ all: $(TEST_PROGS)
top_srcdir = ../../../../..
KSFT_KHDR_INSTALL := 1
include ../../lib.mk
-
-clean:
- rm -fr $(TEST_GEN_FILES)
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] selftests: fix timestamping Makefile
2019-02-13 17:09 [PATCH net] selftests: fix timestamping Makefile Deepa Dinamani
@ 2019-02-13 18:17 ` shuah
2019-02-14 17:03 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: shuah @ 2019-02-13 18:17 UTC (permalink / raw)
To: Deepa Dinamani; +Cc: willemb, netdev, linux-kselftest, shuah
On 2/13/19 10:09 AM, Deepa Dinamani wrote:
> The clean target in the makefile conflicts with the generic
> kselftests lib.mk, and fails to properly remove the compiled
> test programs.
>
> Remove the redundant rule, the TEST_GEN_FILES will be already
> removed by the CLEAN macro in lib.mk.
>
> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> ---
>
> * Changes since v1: as per review comments
>
> tools/testing/selftests/networking/timestamping/Makefile | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tools/testing/selftests/networking/timestamping/Makefile b/tools/testing/selftests/networking/timestamping/Makefile
> index 9050eeea5f5f..1de8bd8ccf5d 100644
> --- a/tools/testing/selftests/networking/timestamping/Makefile
> +++ b/tools/testing/selftests/networking/timestamping/Makefile
> @@ -9,6 +9,3 @@ all: $(TEST_PROGS)
> top_srcdir = ../../../../..
> KSFT_KHDR_INSTALL := 1
> include ../../lib.mk
> -
> -clean:
> - rm -fr $(TEST_GEN_FILES)
>
Thanks for the patch.
Acked-by: Shuah Khan <shuah@kernel.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] selftests: fix timestamping Makefile
2019-02-13 17:09 [PATCH net] selftests: fix timestamping Makefile Deepa Dinamani
2019-02-13 18:17 ` shuah
@ 2019-02-14 17:03 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-02-14 17:03 UTC (permalink / raw)
To: deepa.kernel; +Cc: shuah, willemb, netdev, linux-kselftest
From: Deepa Dinamani <deepa.kernel@gmail.com>
Date: Wed, 13 Feb 2019 09:09:13 -0800
> The clean target in the makefile conflicts with the generic
> kselftests lib.mk, and fails to properly remove the compiled
> test programs.
>
> Remove the redundant rule, the TEST_GEN_FILES will be already
> removed by the CLEAN macro in lib.mk.
>
> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-14 17:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-13 17:09 [PATCH net] selftests: fix timestamping Makefile Deepa Dinamani
2019-02-13 18:17 ` shuah
2019-02-14 17:03 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).