From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4FADC43381 for ; Thu, 14 Feb 2019 17:08:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82639222DA for ; Thu, 14 Feb 2019 17:08:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728292AbfBNRIt (ORCPT ); Thu, 14 Feb 2019 12:08:49 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:56664 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726396AbfBNRIt (ORCPT ); Thu, 14 Feb 2019 12:08:49 -0500 Received: from localhost (96-89-128-221-static.hfc.comcastbusiness.net [96.89.128.221]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 397C414D5ECC8; Thu, 14 Feb 2019 09:08:48 -0800 (PST) Date: Thu, 14 Feb 2019 09:08:47 -0800 (PST) Message-Id: <20190214.090847.1049635913680945391.davem@davemloft.net> To: petrm@mellanox.com Cc: netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, lorenzo.bianconi@redhat.com Subject: Re: [PATCH net-next] net: ip6_gre: Give ERSPAN a fill_info link op of its own From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 14 Feb 2019 09:08:48 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Petr Machata Date: Wed, 13 Feb 2019 19:31:32 +0000 > In commit c706863bc890 ("net: ip6_gre: always reports o_key to > userspace"), ip6gre and ip6gretap tunnels started reporting a TUNNEL_KEY > output flag even if one was not configured at the device. > > When an okey-less ip6gre or ip6gretap netdevice is created, it initially > encapsulates the packets without okey. But any configuration change > (even a non-change such as setting TOS to an already-configured value) > then causes the okey flag from the reported configuration to be > circulated back to actual configuration. From that point on, the device > encapsulates packets with output key of 0. > > The intention was to implement this behavior for ERSPAN devices, not for > all ip6gre devices. The ERSPAN netdevice should really have its own > fill_info callback. Add one. > > Fixes: c706863bc890 ("net: ip6_gre: always reports o_key to userspace") > CC: Lorenzo Bianconi > Signed-off-by: Petr Machata This commit you are fixing exists in the 'net' tree, therefore this is a bug fix and should be targetted at 'net'.