From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23B0EC43381 for ; Thu, 14 Feb 2019 17:22:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F2C21222DA for ; Thu, 14 Feb 2019 17:22:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389769AbfBNRWW (ORCPT ); Thu, 14 Feb 2019 12:22:22 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:56900 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726160AbfBNRWW (ORCPT ); Thu, 14 Feb 2019 12:22:22 -0500 Received: from localhost (96-89-128-221-static.hfc.comcastbusiness.net [96.89.128.221]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 8FBE014D4F4F4; Thu, 14 Feb 2019 09:22:21 -0800 (PST) Date: Thu, 14 Feb 2019 09:22:20 -0800 (PST) Message-Id: <20190214.092220.667100849624830283.davem@davemloft.net> To: huang.zijiang@zte.com.cn Cc: isdn@linux-pingi.de, natechancellor@gmail.com, yuehaibing@huawei.com, baijiaju1990@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, wang.yi59@zte.com.cn Subject: Re: [PATCH] isdn:hisax: Replace dev_kfree_skb_any by dev_consume_skb_any From: David Miller In-Reply-To: <1550126399-28063-1-git-send-email-huang.zijiang@zte.com.cn> References: <1550126399-28063-1-git-send-email-huang.zijiang@zte.com.cn> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 14 Feb 2019 09:22:21 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Huang Zijiang Date: Thu, 14 Feb 2019 14:39:59 +0800 > The skb should be freed by dev_consume_skb_any() in hfcpci_fill_fifo() > when bcs->tx_skb is still used. The bcs->tx_skb is be replaced by > skb_dequeue(&bcs->squeue), so the original bcs->tx_skb should > be consumed(not drop). > > Signed-off-by: Huang Zijiang Applied, thanks.