From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9C79C43381 for ; Thu, 14 Feb 2019 17:47:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 937BE222DA for ; Thu, 14 Feb 2019 17:47:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406263AbfBNRrl (ORCPT ); Thu, 14 Feb 2019 12:47:41 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:57338 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406217AbfBNRrk (ORCPT ); Thu, 14 Feb 2019 12:47:40 -0500 Received: from localhost (96-89-128-221-static.hfc.comcastbusiness.net [96.89.128.221]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 24BE914D63A65; Thu, 14 Feb 2019 09:47:40 -0800 (PST) Date: Thu, 14 Feb 2019 09:47:39 -0800 (PST) Message-Id: <20190214.094739.535607170151691470.davem@davemloft.net> To: bkenward@solarflare.com Cc: linux-net-drivers@solarflare.com, netdev@vger.kernel.org, rstonehouse@solarflare.com Subject: Re: [PATCH net-next] sfc: ensure recovery after allocation failures From: David Miller In-Reply-To: <6beed7df-01e6-a15e-0e19-d40bf0ff945c@solarflare.com> References: <6beed7df-01e6-a15e-0e19-d40bf0ff945c@solarflare.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 14 Feb 2019 09:47:40 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Bert Kenward Date: Thu, 14 Feb 2019 17:27:43 +0000 > From: Robert Stonehouse > > After failing to allocate a receive buffer the driver may fail to ever > request additional allocations. EF10 NICs require new receive buffers to > be pushed in batches of eight or more. The test for whether a slow fill > should be scheduled failed to take account of this. There is little > downside to *always* requesting a slow fill if we failed to allocate a > buffer, so the condition has been removed completely. The timer that > triggers the request for a refill has also been shortened. > > Signed-off-by: Robert Stonehouse > Signed-off-by: Bert Kenward Applied, thanks Bert.