From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D2ECC43381 for ; Thu, 14 Feb 2019 01:17:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 14EB02085A for ; Thu, 14 Feb 2019 01:17:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="UPFHcPTI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729672AbfBNBR1 (ORCPT ); Wed, 13 Feb 2019 20:17:27 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:51014 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726165AbfBNBR0 (ORCPT ); Wed, 13 Feb 2019 20:17:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=aqwR3vPtjl3hG8wKBwm5suBwZE5iYG0D9sXbmwolqUk=; b=UPFHcPTIOSQlF8YyONASicTLy7 SDdt8rtr5lCxpRv806adalhAFCjXeDs+6Sr//GU4gLP7y1pBu+c1+J938Ok4nbqrRMU+TRhhofco7 n3mMTM+QTBfp6ViHBe8j0nUdM+HQbW/Ib4hM4JoN2ICSWy6RS4JAejTOz17f51O2lnVs=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gu5eT-00046n-Qc; Thu, 14 Feb 2019 02:17:21 +0100 Date: Thu, 14 Feb 2019 02:17:21 +0100 From: Andrew Lunn To: Heiner Kallweit Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" , Russell King - ARM Linux Subject: Re: [PATCH net] net: phy: fix interrupt handling in non-started states Message-ID: <20190214011721.GD24589@lunn.ch> References: <25e86edc-0b88-8c03-b692-776e971331f2@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <25e86edc-0b88-8c03-b692-776e971331f2@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 12, 2019 at 07:56:15PM +0100, Heiner Kallweit wrote: > phylib enables interrupts before phy_start() has been called, and if > we receive an interrupt in a non-started state, the interrupt handler > returns IRQ_NONE. This causes problems with at least one Marvell chip > as reported by Andrew. > Fix this by handling interrupts the same as in phy_mac_interrupt(), > basically always running the phylib state machine. It knows when it > has to do something and when not. > This change allows to handle interrupts gracefully even if they > occur in a non-started state. > > Fixes: 2b3e88ea6528 ("net: phy: improve phy state checking") > Reported-by: Andrew Lunn > Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn Andrew