From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 690DAC43381 for ; Thu, 14 Feb 2019 16:03:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2511E218EA for ; Thu, 14 Feb 2019 16:03:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="1QitA/qo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393722AbfBNQDw (ORCPT ); Thu, 14 Feb 2019 11:03:52 -0500 Received: from mail-pl1-f173.google.com ([209.85.214.173]:38440 "EHLO mail-pl1-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391103AbfBNQDv (ORCPT ); Thu, 14 Feb 2019 11:03:51 -0500 Received: by mail-pl1-f173.google.com with SMTP id e5so3373025plb.5 for ; Thu, 14 Feb 2019 08:03:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version :content-transfer-encoding; bh=YMXHESuk68orTo1birwwgnblUsKpdnmQuCO6LOFO5mM=; b=1QitA/qooY+uWgoYmLOZ8cX+n4qVl03MTSxHrp3vcAkP0nGN9ZkOQzzxX3/BJzXT2B 5o2f/vr1v71Ulg1iA/KluZ4cgwTIq9W27Apc/JPi4qggCDn6uRLtoGpzkTUzzte5vfST XVN2/QDUBwVGV/BfE5QESbI3Zz/Gsop4tYx1CXS0zXq40jYHXPu4FK2qK/A797fGAy9J EMfvja2OyNd8o7FqCLeWy6wnJ9RXaorU40ktf85lMOaSjfuJxZwNp7upJ+3TaceoaIqz Y+PlhDl0LeHQpADpWD3YWAkOTNBcrCniCad3tqaWIwxFcqOQ78u5w2DANUEXC1StkhQp jq3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-transfer-encoding; bh=YMXHESuk68orTo1birwwgnblUsKpdnmQuCO6LOFO5mM=; b=ibdYFpMNVZB+/rHUlPVAGsl+WYy3/DmTQtQ6DyNZtqOneIZznO+nRZIZe3VZ8YJYTE AT3fLxgU6prXZ75YdPy1JjX4mFSOC4mpvnKEZ7sbfgXokCGQAxoOQ0NNdeexgsQfdI3B p2/PT76AnwW535N95g9j5dMlTy2kA85YU1XO5zbILnOkCNfQCVTqzJBziwkyWUq9CKKB 7j1afGf+o/d5pNlTYHr94QN/SiL3g9HkR86GOvY1PLFy7tbP4IhLJAhPbicLiku0S9FR IlrCsiCMmJohENWsqvIxxwdECHGfTGYVTSqVpAIHBWqzgGQcIF+jkjZaOa/oev3bcN+c +lJQ== X-Gm-Message-State: AHQUAuYnJV8rjug9TD/W9tYddMRcxbU2Vc2YkUIZoXuG1j77VYlAYUD1 KL7MqYzWJo2ef8/qPm+fbQHjDg== X-Google-Smtp-Source: AHgI3IaxYHED5SWODRUVQrakC4fyI1vzjPBSw8Biq6IzS+XQYyKJSm9SnuCA/LVPg3rTHCAo0N3H/A== X-Received: by 2002:a17:902:6b49:: with SMTP id g9mr4965475plt.291.1550160231074; Thu, 14 Feb 2019 08:03:51 -0800 (PST) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id h64sm4455540pfc.142.2019.02.14.08.03.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Feb 2019 08:03:51 -0800 (PST) Date: Thu, 14 Feb 2019 08:03:46 -0800 From: Stephen Hemminger To: mst@redhat.com, jasowang@redhat.com Cc: netdev@vger.kernel.org Subject: dead code in vhost.c Message-ID: <20190214080346.352c6941@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Coverity found this obvious bug ________________________________________________________________________________________________________ *** CID 1442593: Control flow issues (DEADCODE) /drivers/vhost/vhost.c: 1795 in log_used() 1789 ret = translate_desc(vq, (uintptr_t)vq->used + used_offset, 1790 len, iov, 64, VHOST_ACCESS_WO); 1791 if (ret) 1792 return ret; 1793 1794 for (i = 0; i < ret; i++) { >>> CID 1442593: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "ret = log_write_hva(vq, (ui...". 1795 ret = log_write_hva(vq, (uintptr_t)iov[i].iov_base, 1796 iov[i].iov_len); 1797 if (ret) 1798 return ret; 1799 } 1800