From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29678C43381 for ; Thu, 14 Feb 2019 16:29:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB8AE2085A for ; Thu, 14 Feb 2019 16:29:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="rJp6IVuc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390544AbfBNQ3S (ORCPT ); Thu, 14 Feb 2019 11:29:18 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:43427 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726014AbfBNQ3S (ORCPT ); Thu, 14 Feb 2019 11:29:18 -0500 Received: by mail-pl1-f194.google.com with SMTP id f90so3399271plb.10 for ; Thu, 14 Feb 2019 08:29:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZyCOUACsDwhYjHWI7IKkMiBBKp1heGxeRmYlhYC4n28=; b=rJp6IVucG7vRQ0BSGG0BHXaKAG8X8dyEGjuA2QBzBIVcnCdRUZ4LYZDi3epHrC5N7Y 472Z1cjw+8NtzXSTqGa6zgr/zaWsJGEAsnyWX5TfstW+4RUD4ZSB9HFBbaDKBbpJ84G2 qeTY0nAl5zTa7zdvAxvV1YXqfAl8Ud1Wpx57TGUBjyaAzC+r9TdWtnh2KAxduGOPBiRj eiH67Ut3uodzGyhJKH/I0Bg8BLYlCC7WDwchI2msuFKj3PEfSVP8lhAdMYkyBYgtZf1m lYjjybBxS5P+eIN8wUKuBmw4M20G+ZO7mrEjFORNwPt+Xj4U29HHl3+KNm90sNiSqiTL GlKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZyCOUACsDwhYjHWI7IKkMiBBKp1heGxeRmYlhYC4n28=; b=uBM6QZhXSNuBaKFbXetmjyrAkjUSC7dT9S0L8DbuYFIYhNnd4EAMgiMasW1QKq1bTn c/2//d7xpzi3ScQtoUhkqYS2x1ObfVPiFoLgvrW+U5FdstBc0CYZpNYpqLw2ivSf8SX+ Kj7CNlb61ErIdh6SYl611NTKHC4w2pWCv2uEBANrB+4TSNfbHAKiS4bvmBg/JOcTD1cU /bWI0GYhq145adRAJ5Lt25dPtQiqW7nRHtgs7utWIOdvtwaBRxO8QcP34/8oJUY0ALbA jyLurkUOO2Z5tx7zWju7jXWhkpqHNX2toNnSTbrFI+m0b+lg3hEhayB4xrmYDXNhZ8wj niJg== X-Gm-Message-State: AHQUAubBYmE+D8u3RcGug/3znd5VeInmxINqZI04C9m3s7zO+Opi3Zps kvY7pXcKgLshvRpVg9FwCfDB7g== X-Google-Smtp-Source: AHgI3IYp5nSEmvXhALo3mlLSpoVhSQ/rC8Jc/wfPUekJfIyhvf1EkdOsotw4q6YDYOhQUr9EILw/CA== X-Received: by 2002:a17:902:20e9:: with SMTP id v38mr4928062plg.250.1550161757339; Thu, 14 Feb 2019 08:29:17 -0800 (PST) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id k64sm6409935pfj.69.2019.02.14.08.29.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Feb 2019 08:29:17 -0800 (PST) Date: Thu, 14 Feb 2019 08:29:13 -0800 From: Stephen Hemminger To: Matteo Croce Cc: netdev , David Ahern , Stephen Hemminger , Jakub Kicinski Subject: Re: [PATCH iproute2] iplink: document XDP subcommand to force the XDP mode. Message-ID: <20190214082913.7e2f7897@shemminger-XPS-13-9360> In-Reply-To: References: <20190213144030.15160-1-mcroce@redhat.com> <20190213140403.5fcf761e@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 14 Feb 2019 15:01:26 +0100 Matteo Croce wrote: > On Wed, Feb 13, 2019 at 11:04 PM Stephen Hemminger > wrote: > > > > On Wed, 13 Feb 2019 15:40:30 +0100 > > Matteo Croce wrote: > > > > > When attaching an eBPF program to a device, ip link can force the XDP mode > > > by using the xdp{generic,drv,offload} keyword instead of just 'xdp'. > > > Document this behaviour also in the help output. > > > > > > Signed-off-by: Matteo Croce > > > Fixes: 14683814 ("bpf: add xdpdrv for requesting XDP driver mode") > > > Fixes: 1b5e8094 ("bpf: allow requesting XDP HW offload") > > > > Applied, thanks. > > The man page already has this as well. > > > > Yes, I found it just after I made the patch. However, it could be nice > to have the generic "xdp" and a command like "type" or "mode" to > specify the XDP mode, eg. > ip link set dev eth0 xdp mode [ auto | generic | drv | offload ] > I was trying to add it, but unfortunately it seems that the arguments > aren't parsed in a loop, and are required to be in the exact order. > Would this change make sense? > > Regards, > > -- > Matteo Croce > per aspera ad upstream It would have made sense to start with, but the syntax is more or less fixed by now.