From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E98BC43381 for ; Thu, 14 Feb 2019 14:47:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1EC7B2229F for ; Thu, 14 Feb 2019 14:47:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="a1GgYZ5u" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395072AbfBNOrM (ORCPT ); Thu, 14 Feb 2019 09:47:12 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:42635 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387955AbfBNOrL (ORCPT ); Thu, 14 Feb 2019 09:47:11 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id D7B1E21EEB; Thu, 14 Feb 2019 09:47:10 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 14 Feb 2019 09:47:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=5YQzTr Fvb7ZKCagIV5P+qMeUjGMf6/gaPGsV68VQe5c=; b=a1GgYZ5uHAFjTl01t6QpvI ekjE/GXI08WqTstqChViId4EDInpmLs1l9yg7cWslzWvBTsiHeF59+Ym9Up/Hu60 G9PjQTLfPkQUu/ubtVuHESHFGrAO4Ec1no+PdZiE5CjijN21o36LCwbKm4OC7Z+3 dPco7HQxLssTU3kOKOH84Dg30RlYpY47qtJRpWws70zOLLW4J/W9iZV205TZxDQ1 O3BhqbRZQjETTEnCCZdt1j4woH6UfoZvG+GR2ZLrS+AebmW91CPO0bAAcdVBAMlm C0mbGoO27FyB4WqCXrY5TYRrn99MYarBrMzHMl6qPIq8kVfpYI7Bt8/iBjx6BFcQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledruddthedgieekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvuffkfh ggtggujggfsehttdertddtredvnecuhfhrohhmpefkughoucfutghhihhmmhgvlhcuoehi ughoshgthhesihguohhstghhrdhorhhgqeenucfkphepudelfedrgeejrdduieehrddvhe dunecurfgrrhgrmhepmhgrihhlfhhrohhmpehiughoshgthhesihguohhstghhrdhorhhg necuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (unknown [193.47.165.251]) by mail.messagingengine.com (Postfix) with ESMTPA id 7B9B4E409D; Thu, 14 Feb 2019 09:47:09 -0500 (EST) Date: Thu, 14 Feb 2019 16:47:07 +0200 From: Ido Schimmel To: Jiri Pirko Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com Subject: Re: [patch net-next] lib: objagg: fix handling of object with 0 users when assembling hints Message-ID: <20190214144707.GA14806@splinter> References: <20190214143907.3275-1-jiri@resnulli.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190214143907.3275-1-jiri@resnulli.us> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 14, 2019 at 03:39:07PM +0100, Jiri Pirko wrote: > From: Jiri Pirko > > It is possible that there might be an originally parent object with 0 > direct users that is in hints no longer considered as parent. Then the > weight of this object is 0 and current code ignores him. That's why the > total amount of hint objects might be lower than for the original > objagg and WARN_ON is hit. Fix this be considering 0 weight valid. > > Fixes: 9069a3817d82 ("lib: objagg: implement optimization hints assembly and use hints for object creation") > Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel