From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E6A6C4360F for ; Thu, 14 Feb 2019 15:15:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0DC0F222C9 for ; Thu, 14 Feb 2019 15:15:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="oBL95TvL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407483AbfBNPPw (ORCPT ); Thu, 14 Feb 2019 10:15:52 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:52095 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404080AbfBNPPv (ORCPT ); Thu, 14 Feb 2019 10:15:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/tB5nLNpanCnlsRpO4c+hlftNaV2fOzM0V9IOQQXhKI=; b=oBL95TvL1HNJhv2ok+EDpHYC6v KzHV+/vXm2PtZ+wJnZhhb3/TZS0inerdEs3IQuhwE6zPtVLKIA+G0Dll2kEcqWQrDXp2eRPXE2Xg+ I9vKxIyau49kBtM0maOw8QLexJm+47G0bWt+1Z03EZ67xnRkYaJnehkBH2UCMHCRmVV4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1guIjk-0002zL-3N; Thu, 14 Feb 2019 16:15:40 +0100 Date: Thu, 14 Feb 2019 16:15:40 +0100 From: Andrew Lunn To: Christophe ROULLIER Cc: "robh@kernel.org" , "davem@davemloft.net" , "joabreu@synopsys.com" , "mark.rutland@arm.com" , "mcoquelin.stm32@gmail.com" , Alexandre TORGUE , Peppe CAVALLARO , "linux-stm32@st-md-mailman.stormreply.com" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH 2/8] net: ethernet: stmmac: update to support all PHY config for stm32mp157c. Message-ID: <20190214151540.GG708@lunn.ch> References: <1550126763-22669-1-git-send-email-christophe.roullier@st.com> <1550126763-22669-3-git-send-email-christophe.roullier@st.com> <20190214134040.GA5699@lunn.ch> <02cd7773-899f-b28a-ff61-849b17cbe82d@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <02cd7773-899f-b28a-ff61-849b17cbe82d@st.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > Sorry, I've misunderstood your question ;-) > > And you spoke about : > > case PHY_INTERFACE_MODE_RGMII: > case PHY_INTERFACE_MODE_RGMII_ID: > case PHY_INTERFACE_MODE_RGMII_RXID: > case PHY_INTERFACE_MODE_RGMII_TXID: > > So in my setup I've only RGMII interface, so I've never tested 3 others > interfaces (_ID, _RXID, _TXID). > > So do I need to add cases in my driver ? Yes. They all indicate the MAC should be using RGMII. This appears to be an old issue, but now would be a good time to fix it. Andrew