From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E9A1C43381 for ; Thu, 14 Feb 2019 15:41:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D9A0A222A1 for ; Thu, 14 Feb 2019 15:41:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="nHYIl3nk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502231AbfBNPlj (ORCPT ); Thu, 14 Feb 2019 10:41:39 -0500 Received: from mail-eopbgr80071.outbound.protection.outlook.com ([40.107.8.71]:31051 "EHLO EUR04-VI1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2502193AbfBNPli (ORCPT ); Thu, 14 Feb 2019 10:41:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xM8zqeve2Ubl4f1B8fGtJFtm6xHttZpBKB/OByEa/i8=; b=nHYIl3nk4UWpDPeX5b/STii+oIv3zlNDdMvmQ/yZ7/XrDz+xCTr8DHZTcKG9Edv2YdSCj1HouoT00WXasonBUNE7PzGK4BMEq8szLzjR6fDDB9Y3k/Jxl0UfDxxiwrt5HIyvMt3ulC2vG5JtlmaZx7LljE6iDF9oBJvA3wpL0EE= Received: from DBBPR05MB6570.eurprd05.prod.outlook.com (20.179.44.81) by DBBPR05MB6587.eurprd05.prod.outlook.com (20.179.44.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1601.21; Thu, 14 Feb 2019 15:41:34 +0000 Received: from DBBPR05MB6570.eurprd05.prod.outlook.com ([fe80::34e8:76a2:998f:581a]) by DBBPR05MB6570.eurprd05.prod.outlook.com ([fe80::34e8:76a2:998f:581a%7]) with mapi id 15.20.1601.023; Thu, 14 Feb 2019 15:41:34 +0000 From: Jason Gunthorpe To: Raju Rangoju CC: "davem@davemloft.net" , "linux-rdma@vger.kernel.org" , "netdev@vger.kernel.org" , "swise@opengridcomputing.com" Subject: Re: [rdma-rc PATCH 2/2] iw_cxgb4: cq/qp mask depends on bar2 pages in a host page Thread-Topic: [rdma-rc PATCH 2/2] iw_cxgb4: cq/qp mask depends on bar2 pages in a host page Thread-Index: AQHUxF5xAU0YMH+g/UiCbC7ukVhhWKXfbsGA Date: Thu, 14 Feb 2019 15:41:34 +0000 Message-ID: <20190214154127.GD1725@mellanox.com> References: <20190214121054.11693-1-rajur@chelsio.com> <20190214121054.11693-3-rajur@chelsio.com> In-Reply-To: <20190214121054.11693-3-rajur@chelsio.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MWHPR10CA0008.namprd10.prod.outlook.com (2603:10b6:301::18) To DBBPR05MB6570.eurprd05.prod.outlook.com (2603:10a6:10:d1::17) authentication-results: spf=none (sender IP is ) smtp.mailfrom=jgg@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [174.3.196.123] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fe98794a-0a15-488a-8469-08d69292e5fd x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(7193020);SRVR:DBBPR05MB6587; x-ms-traffictypediagnostic: DBBPR05MB6587: x-microsoft-exchange-diagnostics: =?us-ascii?Q?1;DBBPR05MB6587;23:YfydrHl28bvH6QUcA4eI81JGF9JZX7v2+dierxfDf?= =?us-ascii?Q?L8Wp+QHntqFY58ZLhUDREtMabnaGaLmO2R2vni4phngbyPewmdm4KD/9T8Uo?= =?us-ascii?Q?NNC2aoTkDfAWIP/APNI8DcCdg5Z8cYVk3zUjw/C3wYH58zFBlTvNll1AnPN5?= =?us-ascii?Q?oa6YWLakeYjNCxdVPPMv1dQY+fqRP4jmyz8uRBeEHW3ucRmqoq0NbDUebFVC?= =?us-ascii?Q?AfFwMmuZAEpAqxS5OJaNpkIyjXSeaNlrK0nfKYuqpB58aVzxz8PBs9SX1X1U?= =?us-ascii?Q?1MvCL9/QGqaS0bJR716EMGVV8TJx4NhqbGUI0OtF5wouD68Ql5BslrW4rxaj?= =?us-ascii?Q?oQI7C3mpdLrLOiHvFmzwK2YmCTzQn4Hl9lCzef/Lce1mEAnoxzV7/KzofXYV?= =?us-ascii?Q?hFsJDzNHCnBDs3eejI94oKqIC2SYYOGCfxY91HmfgrLAOFX0OOCxi4JZA2wQ?= =?us-ascii?Q?8lrnnZ5O9m/RN+q1veCb+j3bSzjTOwFzVD6LEAYbGiOkufcqE1nBdcuRzJlB?= =?us-ascii?Q?SfA2Eh9xvqPU5+vi7hv0IzDsIy9ojrmp117WiRIrt+l1L8oyGdTCGhD8WSAh?= =?us-ascii?Q?2L0bUIUQJ8RGbISlA82ZEh+hI2dU84sbdHmnntvc2WQuztmW0YFgqH74b7xr?= =?us-ascii?Q?31CO9HQ36KwDTmGz0JbyBkrFQERWEdb9dWSn47RfzdlTs7ppXOaOA2lrAx2O?= =?us-ascii?Q?fiWUTkAJOD+UXh/Ey6kumK6UARTE2tGu+uMgGlDiO6zQ4GG8VJ1oXvgzFHT0?= =?us-ascii?Q?GRGv3HEiDawky/Q1e8qYlZgT73bCOcunTNT5Ij9JjinhK8mUBJCBYaAY+1zu?= =?us-ascii?Q?O/qnH++KzMD3J0htNoRKRv6c00m5QZ8ktdVcokp+o9e+UlIHa4smcHZ0wt+H?= =?us-ascii?Q?RXYhEOmQQR5Fw5onr17yDtARyXUigCCdsv0UrBVisD7B2dRwECOKz3lxTWOZ?= =?us-ascii?Q?qy+Xme9Kc3hisEWEwywwlEY83NzJkCRkkd8mW4QggYk/6dM0MLAr5mnAoDno?= =?us-ascii?Q?17Yz83H31XkW/864LUhQFm+i64B4UgzHFzJCzojZkaA3wf4TI7WX6RwsQl/1?= =?us-ascii?Q?SA1B0iZI6JlOcrxSt4PfAYsOWGjrbWBRocNDtS8wOGGWSniu3gb7Gdb7jk6+?= =?us-ascii?Q?xGLyWypZcyNW9s59WnviAWGJD7KpuuvJVxycaoYssZ3nBHDNkc59cTspSKyI?= =?us-ascii?Q?2GsX2+5L243I4v8Zzm+74JMfClk2N31G/XzhwDnl/up3ayU0nUN5KvI0Q=3D?= =?us-ascii?Q?=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09480768F8 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(366004)(346002)(396003)(136003)(39860400002)(376002)(199004)(189003)(14454004)(66066001)(446003)(68736007)(3846002)(229853002)(11346002)(6116002)(486006)(102836004)(2616005)(86362001)(6506007)(476003)(6916009)(71200400001)(6512007)(386003)(305945005)(2906002)(71190400001)(33656002)(4744005)(76176011)(81166006)(316002)(4326008)(7736002)(54906003)(105586002)(8936002)(256004)(8676002)(81156014)(6246003)(25786009)(26005)(36756003)(478600001)(53936002)(99286004)(186003)(6436002)(97736004)(1076003)(106356001)(6486002)(52116002);DIR:OUT;SFP:1101;SCL:1;SRVR:DBBPR05MB6587;H:DBBPR05MB6570.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 9eCga3odJ8ud2zncKvD9tI9mAIYHzVzlIPUYCBLWa4pCXec8q5fZjH8Mg2QXQFFMUdwT7ma6gcyU43F2T0YcqgHrbdkoIMFjB8chugRnxH7nOXouuBiOwkhfr2+xzGt36RE6Dnt/OTZ9bNJqFZwXhJ/xU+hD0DE0V/2/PJEoEgxTZbmFJ9m0IdiVs3RDF9ZWeHzBPo0pFSe6jAUmn17b5DQA46UHUzv/CQQXykX2QbZhl6vEc/R/oL9grymfJlX123H3A4a3BIIhcOWS3z3i1ehzZqnYi4gm00eGFv1HpjxueSCVBMtRKBNfuXo85e0RETvBmfm9nA/LJZkV9UEjLHPggHQ8kjwEOXq6N4h+tPtv6tx3hu5Gy0kJvlF5093qWNQWOXZwNe5yzg5Y2Kn9+stqHNx/sjVB4H3H/RwUTQ8= Content-Type: text/plain; charset="us-ascii" Content-ID: <71B9D036799BE642AE1FFFBBFF1456CE@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe98794a-0a15-488a-8469-08d69292e5fd X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2019 15:41:34.0971 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR05MB6587 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 14, 2019 at 05:40:54PM +0530, Raju Rangoju wrote: > Adjust the cq/qp mask based on no.of bar2 pages in a host page. >=20 > For user-mode rdma, the granularity of the BAR2 memory mapped > to a user rdma process during queue allocation must be based > on the host page size. The lld attributes udb_density and > ucq_density are used to figure out how many sge contexts are > in a bar2 page. So the rdev->qpmask and rdev->cqmask in > iw_cxgb4 need to now be adjusted based on how many sge bar2 > pages are in a host page. Why is this rc? Do certain arches fail to work or something? Jason