From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 934F6C43381 for ; Thu, 14 Feb 2019 17:28:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 69B4621928 for ; Thu, 14 Feb 2019 17:28:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395177AbfBNR2L (ORCPT ); Thu, 14 Feb 2019 12:28:11 -0500 Received: from stargate.chelsio.com ([12.32.117.8]:26231 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395105AbfBNR2J (ORCPT ); Thu, 14 Feb 2019 12:28:09 -0500 Received: from localhost (kumbhalgarh.blr.asicdesigners.com [10.193.185.255]) by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id x1EHS3Xw005914; Thu, 14 Feb 2019 09:28:03 -0800 Date: Thu, 14 Feb 2019 22:58:02 +0530 From: Raju Rangoju To: Jason Gunthorpe Cc: "davem@davemloft.net" , "linux-rdma@vger.kernel.org" , "netdev@vger.kernel.org" , "swise@opengridcomputing.com" Subject: Re: [rdma-rc PATCH 2/2] iw_cxgb4: cq/qp mask depends on bar2 pages in a host page Message-ID: <20190214172801.GA12408@chelsio.com> References: <20190214121054.11693-1-rajur@chelsio.com> <20190214121054.11693-3-rajur@chelsio.com> <20190214154127.GD1725@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190214154127.GD1725@mellanox.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thursday, February 02/14/19, 2019 at 15:41:34 +0000, Jason Gunthorpe wrote: > On Thu, Feb 14, 2019 at 05:40:54PM +0530, Raju Rangoju wrote: > > Adjust the cq/qp mask based on no.of bar2 pages in a host page. > > > > For user-mode rdma, the granularity of the BAR2 memory mapped > > to a user rdma process during queue allocation must be based > > on the host page size. The lld attributes udb_density and > > ucq_density are used to figure out how many sge contexts are > > in a bar2 page. So the rdev->qpmask and rdev->cqmask in > > iw_cxgb4 need to now be adjusted based on how many sge bar2 > > pages are in a host page. > > Why is this rc? Do certain arches fail to work or something? > Yes, this series fixes a regression that was introduced by commit 2391b0030e (v5.0-rc1~129^2~272) > Jason