From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9CABC43381 for ; Fri, 15 Feb 2019 02:25:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B648B2073D for ; Fri, 15 Feb 2019 02:25:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550197527; bh=nkZLeW/kU7GIxdmBX93jo+iXTKEI6d9z5RS3j5QXh90=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=t21oA7wPDEC6+Or/bCoRKvCBL3Y7x557L67ttgebqcrpCoMNMCb0YCmHppr03Ua/7 4NhrrITg4JsJpFeDv4vR0qmqtxcBW5XUW3PSUEWA285Z0yEDbIRJyBWLyGHxILu9ms g2hgjmYjtOP2GwS9qRIpRE5LHZtSRH/WqhtDnWWk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729393AbfBOCZV (ORCPT ); Thu, 14 Feb 2019 21:25:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:54032 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391559AbfBOCOI (ORCPT ); Thu, 14 Feb 2019 21:14:08 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DF23B21934; Fri, 15 Feb 2019 02:14:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550196847; bh=nkZLeW/kU7GIxdmBX93jo+iXTKEI6d9z5RS3j5QXh90=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OYhJHKquAkSQ4XmUTLUSgOqmF4p8JTVKPRC2/HO374+v+zZyxLa+cIJVRqvL4u3gf nS2g4UEFJCGIkDcsg8+Zu7CfMXEEfUeD2d8c8pjZ75FObpeD1AOkLIHDIb/euHAQPh 6RTFtd+17Rrddy2wZ3y/bwehAR10GgekXv7dQG/U= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Atsushi Nemoto , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 29/40] net: altera_tse: fix connect_local_phy error path Date: Thu, 14 Feb 2019 21:13:02 -0500 Message-Id: <20190215021313.178476-29-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190215021313.178476-1-sashal@kernel.org> References: <20190215021313.178476-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Atsushi Nemoto [ Upstream commit 17b42a20d7ca59377788c6a2409e77569570cc10 ] The connect_local_phy should return NULL (not negative errno) on error, since its caller expects it. Signed-off-by: Atsushi Nemoto Acked-by: Thor Thayer Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/altera/altera_tse_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c index 527908c7e384..84def1ff6cb6 100644 --- a/drivers/net/ethernet/altera/altera_tse_main.c +++ b/drivers/net/ethernet/altera/altera_tse_main.c @@ -714,8 +714,10 @@ static struct phy_device *connect_local_phy(struct net_device *dev) phydev = phy_connect(dev, phy_id_fmt, &altera_tse_adjust_link, priv->phy_iface); - if (IS_ERR(phydev)) + if (IS_ERR(phydev)) { netdev_err(dev, "Could not attach to PHY\n"); + phydev = NULL; + } } else { int ret; -- 2.19.1