From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 241F2C43381 for ; Fri, 15 Feb 2019 15:44:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5A702192D for ; Fri, 15 Feb 2019 15:44:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="hpKyAdI1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731374AbfBOPoe (ORCPT ); Fri, 15 Feb 2019 10:44:34 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:38053 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727174AbfBOPoe (ORCPT ); Fri, 15 Feb 2019 10:44:34 -0500 Received: by mail-pf1-f193.google.com with SMTP id q1so5007291pfi.5 for ; Fri, 15 Feb 2019 07:44:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=ZjhkXOJdoP/+9VUIvg7fvFUVMOjUxksj3jV7aYTZt0M=; b=hpKyAdI1XXMRAdcCy7InCT1RpqAaJjcT3TAuK4T8Q2u3T51E8HD9OiGha3PM0QAgh4 Vhhal3/xLa7qaMIJC8DNjpEaaDGsJuaM1rfMCtC0Dvya1NgULb3II1jbfSNignqXNcDN HEiaVBDHYIuMTz5aCc9XcKnOG+iG9OC1GC4U1edCjMm5iHdLUQykXgIQsFvJtde+Tgmw DJf1qNr61DUJEXZ1x10fCGbGgcHocBfbm5Z3YTuKJ4iXvta/+ST7XmKstfxD+EpsnU2k 9AfBryEUIdBMOzqIGLxKzecSN9nv1klv8/fP69yCV6PWw6wRyMO+nDqu2vky4TNtPg+R xxsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=ZjhkXOJdoP/+9VUIvg7fvFUVMOjUxksj3jV7aYTZt0M=; b=WpYEtNt1RaXNvN03gwNSt5gt8wVS44fhT023K1HnBEApngljCVtcRzXFN//FeKgjY8 +f3rtUGWgYnsSp0IqEeak7ZfUBwZRreCVyHr7eQg/fC/6QElLehSeH/MK6I58Oqq8Zfl 4bCIWHk9eQIPU+WxjR1IgcjN9HAAbX8UAa0Weymq3WS9y5fZPgnOLMT5ZxDKvxO67998 qTecKW4b+3vOhq+dpWr8wWfG17zePzzvgjs+zH27EHdcQT328QjrzPfDhjmhFzKEgIpV Wqulibpjm7ncffJqJfVFcljEd7tbuyx2gYOMkqOFPASN905iquD9wN3owV32r037O8jO 1gWQ== X-Gm-Message-State: AHQUAubnqjwuMePVLYaw37aNkmvpdDq+51Z5xxT108V/7vVSNfYH441E 1U9I19jJrlrdzufYa1cF4EQQUzHgNslSRg== X-Google-Smtp-Source: AHgI3IZYaSEC3R1KgVg9l4UBgUDWycW/ciblmls6H6/fJwTCgI3S5SiSzjmQ1YcgtEPnzhhEwsrkcQ== X-Received: by 2002:a65:4807:: with SMTP id h7mr5834321pgs.15.1550245473933; Fri, 15 Feb 2019 07:44:33 -0800 (PST) Received: from cakuba.netronome.com ([2601:646:8e00:1b7a::2]) by smtp.gmail.com with ESMTPSA id t3sm6043684pgp.5.2019.02.15.07.44.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Feb 2019 07:44:33 -0800 (PST) Date: Fri, 15 Feb 2019 07:44:29 -0800 From: Jakub Kicinski To: Jiri Pirko Cc: davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com, mkubecek@suse.cz, andrew@lunn.ch Subject: Re: [PATCH net-next 3/3] nfp: devlink: allow flashing the device via devlink Message-ID: <20190215074429.6890e47e@cakuba.netronome.com> In-Reply-To: <20190215101514.GD2343@nanopsycho> References: <20190214214046.19182-1-jakub.kicinski@netronome.com> <20190214214046.19182-4-jakub.kicinski@netronome.com> <20190215101514.GD2343@nanopsycho> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 15 Feb 2019 11:15:14 +0100, Jiri Pirko wrote: > > static const struct ethtool_ops nfp_net_ethtool_ops = { > > Why don't you use the compat fallback? I think you should. You and Michal both asked the same so let me answer the first to ask :) - if devlink is built as a module the fallback is not reachable.