From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBD53C43381 for ; Fri, 15 Feb 2019 10:19:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A86E21A80 for ; Fri, 15 Feb 2019 10:19:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="PaTludLd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388148AbfBOKTn (ORCPT ); Fri, 15 Feb 2019 05:19:43 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:42518 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388071AbfBOKTn (ORCPT ); Fri, 15 Feb 2019 05:19:43 -0500 Received: by mail-wr1-f67.google.com with SMTP id q18so9702047wrx.9 for ; Fri, 15 Feb 2019 02:19:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2S4yWIisD54B5Ug4n56PiRX3GF9B+N2htQokddRVPtU=; b=PaTludLdbxFyBV2+riK7AC9AkSoq1bjHbmrF81Vi5PtU0WdjnGOEYY65YPcVqLhnqP kQmKLjYtu9q4zu7LHM3y6WKk2oLfG12xBTvqLbk99lQqwta7G0CD3bsq/q8k/2923yJo 9TBzSxRIT6440+bUGmZjpu0aLD2vJHRVdRFdVPw0RzpYKs4zlSQLMy4kXcbheeFkse62 /kDo8RE3i4fax4xi0spsGw2e4tHUlQlm1JTthovNhfiBfids5sbjiM6xPmBAAL78Crfj TwQJyb2l64iG2xHPm2OwtKEdDYcf4u6gIS37GGfw13bxK0otJegnuLf0RZC2fcCdsMDK ksdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2S4yWIisD54B5Ug4n56PiRX3GF9B+N2htQokddRVPtU=; b=KljHwVUI+QwTt27ZcrmLSu4Tf7T+Vpzm17OjM2iFtHQEb0A4V1L/ikHzKdi0aEJxw6 bLn9q0VgqDxnnssZ85zUSfk24OoR2cI8ksk3yoqCKY9eoXgT1K6D0G4v2RVR+kwnPh04 Oc4ZOzIuqXVpv4lkJyAGWoLn5z+bhq+BzjlslRIf7A2rNZNSVc/XMiEQVxQGSTFU9XvN +SiX5SrIcQoWTZ690v9K0L8a0Sy3ELeJKZmjUIK3x0KY3SDt24c3zZ2uTdWa+c7Sa1Oi UuqLRlwSfFA0Vj0S58urwvR7bbZmOo5+4qDOF7eFvXQcUQzyI56cLepJ7ef4gg9Y/G0j iHBg== X-Gm-Message-State: AHQUAuYuAFKGMRmiDdjhjlO+uMfi5U8uHfpRw4DgmsRszZjl2g099nQO w9Dkf/n5c2AQphssJ3qk8RYmzBOIzlKVyA== X-Google-Smtp-Source: AHgI3IbraqAoblAD32+it2GuJPPRrUXUVp0USrPE3xGOGG4jKn/V2BfF+HwRHS7/oLI8V6mdUs5MXQ== X-Received: by 2002:adf:fd07:: with SMTP id e7mr6738638wrr.175.1550225981318; Fri, 15 Feb 2019 02:19:41 -0800 (PST) Received: from localhost (ip-89-177-129-54.net.upcbroadband.cz. [89.177.129.54]) by smtp.gmail.com with ESMTPSA id p4sm3141633wrs.74.2019.02.15.02.19.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Feb 2019 02:19:40 -0800 (PST) Date: Fri, 15 Feb 2019 11:10:12 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com, mkubecek@suse.cz, andrew@lunn.ch Subject: Re: [PATCH net-next 1/3] devlink: add flash update command Message-ID: <20190215101012.GB2343@nanopsycho> References: <20190214214046.19182-1-jakub.kicinski@netronome.com> <20190214214046.19182-2-jakub.kicinski@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190214214046.19182-2-jakub.kicinski@netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thu, Feb 14, 2019 at 10:40:44PM CET, jakub.kicinski@netronome.com wrote: >Add devlink flash update command. Advanced NICs have firmware >stored in flash and often cryptographically secured. Updating >that flash is handled by management firmware. Ethtool has a >flash update command which served us well, however, it has two >shortcomings: > - it takes rtnl_lock unnecessarily - really flash update has > nothing to do with networking, so using a networking device > as a handle is suboptimal, which leads us to the second one: > - it requires a functioning netdev - in case device enters an > error state and can't spawn a netdev (e.g. communication > with the device fails) there is no netdev to use as a handle > for flashing. > >Devlink already has the ability to report the firmware versions, >now with the ability to update the firmware/flash we will be >able to recover devices in bad state. > >To enable updates of sub-components of the FW allow passing >component name. This name should correspond to one of the >versions reported in devlink info. > >v1: - replace target id with component name (Jiri). > >Signed-off-by: Jakub Kicinski Acked-by: Jiri Pirko