From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F161C4360F for ; Fri, 15 Feb 2019 10:26:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF49121924 for ; Fri, 15 Feb 2019 10:26:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="GYjeAusd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405560AbfBOK0o (ORCPT ); Fri, 15 Feb 2019 05:26:44 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:34576 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727084AbfBOK0o (ORCPT ); Fri, 15 Feb 2019 05:26:44 -0500 Received: by mail-wr1-f65.google.com with SMTP id f14so9804063wrg.1 for ; Fri, 15 Feb 2019 02:26:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lCKjZGVOsW6SX7AHPpacckAXSVTz2MlEkaRmWFAMrlM=; b=GYjeAusdAB3t4AdGG7Clb2byndYPy7rS2LQFqKqarWyRzG4SvgM/WX3b+3AedXYZRV FWHO6DHGUdSvyEvmScL0SmecEUKb6LT22/P4KO2MjKsVfBwwzz3auQwu/C2yuIMxflSD g/ztCQZh8M7RXI3eXrb2JXVtLbT664c+M11Nu+/63nI68dmvjeLiLNS7qy0fGZVH8PcW NBPPS2KKdHYKTFNPLYjwMWNa2Z/3xCBkOoWlXn1f6iPv0ivEAs+PNuMJkoFdITGfBR6t nQA9r1XSROC5RbKQpx+i/gM7F+oD6pSBGROAzsudcpJM8VPT346TyzEcmbol/QOEom3o rJNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lCKjZGVOsW6SX7AHPpacckAXSVTz2MlEkaRmWFAMrlM=; b=rO8a80tuN54hyTaGr2lgm60KuD1QrHUKNkqzLC8jwH0dS1X9aFa5fBqNflfKZuIlmW DR5Ha/cHkEq2AILtHb7Dx52d8a//wdGTn+HDMaq9Wkla3iNzy0DuTNh1lZlSp6wHJ40Q 5drn6c7boDjhH65tPlaP4T9xeuiNRPLPGiEfIlM/DWAANyvl4fdzr7LsUt/IXD2mwDXp dnJ/1gVPQMKoVpGzJmXaV7DB/BSGXzgh8kxQHMOl0j7VEVF2vRSteGk5jQ1f6vWs1OwV DmH1voX7pXpO2q7RuSJaL9FVBFQd0at9iiIe7SXZyaMrj5CWDWzh1s8A9Om9M42H22wv Q4VA== X-Gm-Message-State: AHQUAubMua9ddpFsjDggtD7ZC/ZjrSKrZpo0IUgd66dRIhFHGG7mNb0g /4MzCwMmh6WJIN0/6Dy2S4snkQ== X-Google-Smtp-Source: AHgI3IbIOjHgSnd4AKtZPQIbJ2stQvw1G/4s4IbOid6zYiMAxyVAnjG/PIlAVhO04hoUdoMhU8C1TQ== X-Received: by 2002:adf:e98c:: with SMTP id h12mr6578946wrm.302.1550226401806; Fri, 15 Feb 2019 02:26:41 -0800 (PST) Received: from localhost (ip-89-177-129-54.net.upcbroadband.cz. [89.177.129.54]) by smtp.gmail.com with ESMTPSA id 62sm10435911wra.46.2019.02.15.02.26.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Feb 2019 02:26:41 -0800 (PST) Date: Fri, 15 Feb 2019 11:17:13 +0100 From: Jiri Pirko To: Michal Kubecek Cc: netdev@vger.kernel.org, Jakub Kicinski , davem@davemloft.net, oss-drivers@netronome.com, andrew@lunn.ch Subject: Re: [PATCH net-next 2/3] ethtool: add compat for flash update Message-ID: <20190215101713.GE2343@nanopsycho> References: <20190214214046.19182-1-jakub.kicinski@netronome.com> <20190214214046.19182-3-jakub.kicinski@netronome.com> <20190215085315.GL25518@unicorn.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190215085315.GL25518@unicorn.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fri, Feb 15, 2019 at 09:53:15AM CET, mkubecek@suse.cz wrote: >On Thu, Feb 14, 2019 at 01:40:45PM -0800, Jakub Kicinski wrote: >> If driver does not support ethtool flash update operation >> call into devlink. >> >> Signed-off-by: Jakub Kicinski >> --- >... >> diff --git a/net/core/devlink.c b/net/core/devlink.c >> index bd507e13bb7b..d169b5426d3d 100644 >> --- a/net/core/devlink.c >> +++ b/net/core/devlink.c >> @@ -6435,6 +6435,36 @@ void devlink_compat_running_version(struct net_device *dev, >> mutex_unlock(&devlink_mutex); >> } >> >> +int devlink_compat_flash_update(struct net_device *dev, const char *file_name) >> +{ >> + struct devlink_port *devlink_port; >> + struct devlink *devlink; >> + >> + mutex_lock(&devlink_mutex); >> + list_for_each_entry(devlink, &devlink_list, list) { >> + mutex_lock(&devlink->lock); >> + list_for_each_entry(devlink_port, &devlink->port_list, list) { >> + int ret = -EOPNOTSUPP; >> + >> + if (devlink_port->type != DEVLINK_PORT_TYPE_ETH || >> + devlink_port->type_dev != dev) >> + continue; >> + >> + mutex_unlock(&devlink_mutex); >> + if (devlink->ops->flash_update) >> + ret = devlink->ops->flash_update(devlink, >> + file_name, >> + NULL, NULL); >> + mutex_unlock(&devlink->lock); >> + return ret; >> + } >> + mutex_unlock(&devlink->lock); >> + } >> + mutex_unlock(&devlink_mutex); >> + >> + return -EOPNOTSUPP; >> +} >> + >> static int __init devlink_module_init(void) >> { >> return genl_register_family(&devlink_nl_family); > >We already have similar lookup in devlink_compat_running_version() (the >only difference seems to be that we keep holding devlink_mutex until the >end there) and it's likely the net_device -> devlink lookup will be >needed in more places in the future. How about having a helper for it? > >I also wonder how does the lookup scale. But I don't have clear idea >how long the lists can become in real life and the ethtool operations >are not really time critical. Another thing is, that you don't really have to do the lookup. If you have struct net_device *dev inside the driver, you can get the devlink instance according to that. So it is just a matter of another ndo I guess. > >Michal Kubecek