From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BD35C10F00 for ; Sun, 17 Feb 2019 02:10:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 15780222A3 for ; Sun, 17 Feb 2019 02:10:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728185AbfBQCKy (ORCPT ); Sat, 16 Feb 2019 21:10:54 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:59406 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727175AbfBQCKy (ORCPT ); Sat, 16 Feb 2019 21:10:54 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1C2B214F7D358; Sat, 16 Feb 2019 18:10:53 -0800 (PST) Date: Sat, 16 Feb 2019 18:10:50 -0800 (PST) Message-Id: <20190216.181050.693622468464700230.davem@davemloft.net> To: gnault@redhat.com Cc: netdev@vger.kernel.org, linux-api@vger.kernel.org, edumazet@google.com, mleitner@redhat.com, pabeni@redhat.com Subject: Re: [PATCH net-next] sock: consistent handling of extreme SO_SNDBUF/SO_RCVBUF values From: David Miller In-Reply-To: <2cb69b6987b6e23f8b8c1aa8dc524efa6bd53191.1550026643.git.gnault@redhat.com> References: <2cb69b6987b6e23f8b8c1aa8dc524efa6bd53191.1550026643.git.gnault@redhat.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 16 Feb 2019 18:10:53 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Guillaume Nault Date: Wed, 13 Feb 2019 04:30:34 +0100 > SO_SNDBUF and SO_RCVBUF (and their *BUFFORCE version) may overflow or > underflow their input value. This patch aims at providing explicit > handling of these extreme cases, to get a clear behaviour even with > values bigger than INT_MAX / 2 or lower than INT_MIN / 2. ... > Signed-off-by: Guillaume Nault Thank you so much for writing such a detailed commit message. Applied.