From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AD12C43381 for ; Sat, 16 Feb 2019 18:44:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D9E65222DD for ; Sat, 16 Feb 2019 18:44:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732354AbfBPSoe convert rfc822-to-8bit (ORCPT ); Sat, 16 Feb 2019 13:44:34 -0500 Received: from shiva144.upmc.fr ([134.157.0.144]:38534 "EHLO shiva144.upmc.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726035AbfBPSoe (ORCPT ); Sat, 16 Feb 2019 13:44:34 -0500 Received: from shiva144.upmc.fr (localhost [127.0.0.1]) by shiva144.upmc.fr (Postfix) with ESMTP id 04BD46109F; Sat, 16 Feb 2019 19:44:32 +0100 (CET) Received: from courriel.upmc.fr (courriel5.reseau.jussieu.fr [134.157.0.196]) by shiva144.upmc.fr (Postfix) with ESMTP id EAC686103C; Sat, 16 Feb 2019 19:44:31 +0100 (CET) X-CIds: courriel5 Received: from draws-f6bvp (astlambert-652-1-155-71.w92-151.abo.wanadoo.fr [92.151.34.71]) (authentified, mech=LOGIN) by courriel.upmc.fr (8.14.5/jtpda-5.5pre1) with ESMTP id x1GIiVJm064034 (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256 verify=NO) ; Sat, 16 Feb 2019 19:44:31 +0100 (CET) (envelope-from f6bvp@free.fr) Date: Sat, 16 Feb 2019 19:44:23 +0100 From: f6bvp To: netdev@vger.kernel.org, linux-hams@vger.kernel.org Cc: dvyukov@google.com, richard@rns-stearn.co.uk, thomas@osterried.de, f6bvp@amsat.org Subject: [ROSE] Bug : waiting for rose module to become free Message-ID: <20190216194423.3727d498@draws-f6bvp> Organization: http://radiotelescope-lavillette.fr X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, A nastly bug is still pending in ROSE module that prevents it to be removed. When trying to remove rose module we enter into an endless loop with displayed message : "waiting for rose module to become free" A patch from Richard Stern had been committed a while ago but it did not get a chance to be applied. https://marc.info/?l=linux-hams&m=150870350516064&w=2 Since then, there have been some changes in af_rose.c and net code architecture that prevents simply adding missing dev_put(dev) in present kernel. >From time to time we can observe a negative count (-1 for integer value is displayed as 65535 in /proc/net/rose_neigh) that probably means there is a bug in rose module refcount (??). /proc/net/rose_neigh 00015 SV1HCC-9 ax0 2 1 DCE yes 0 0 00013 PE1OWG-11 ax0 2 65535 DCE yes 0 0 00011 F5KTR-11 ax0 1 1 DCE yes 0 0 00007 F3KT-11 ax0 2 1 DCE yes 0 0 00003 SK7ES-9 ax0 2 1 DTE yes 0 0 00002 K4GBB-9 ax0 4 0 DCE yes 0 0 00001 RSLOOP-0 ??? 1 2 DCE yes 0 0 Help is kindly requested to get a valid patch. Bernard, f6bvp