From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=3zF8=QY=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 25996C10F06
	for <netdev@archiver.kernel.org>; Sun, 17 Feb 2019 18:15:36 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 0029E217F5
	for <netdev@archiver.kernel.org>; Sun, 17 Feb 2019 18:15:35 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1725774AbfBQSOo (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Sun, 17 Feb 2019 13:14:44 -0500
Received: from shards.monkeyblade.net ([23.128.96.9]:39374 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725355AbfBQSOn (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sun, 17 Feb 2019 13:14:43 -0500
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 4D6A1106F2CBA;
        Sun, 17 Feb 2019 10:14:43 -0800 (PST)
Date:   Sun, 17 Feb 2019 10:14:40 -0800 (PST)
Message-Id: <20190217.101440.744217887687576351.davem@davemloft.net>
To:     idosch@mellanox.com
Cc:     netdev@vger.kernel.org, jiri@mellanox.com, petrm@mellanox.com,
        mlxsw@mellanox.com
Subject: Re: [PATCH net] mlxsw: __mlxsw_sp_port_headroom_set(): Fix a use
 of local variable
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190217071809.19295-1-idosch@mellanox.com>
References: <20190217071809.19295-1-idosch@mellanox.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 17 Feb 2019 10:14:43 -0800 (PST)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: Ido Schimmel <idosch@mellanox.com>
Date: Sun, 17 Feb 2019 07:18:41 +0000

> From: Petr Machata <petrm@mellanox.com>
> 
> The function-local variable "delay" enters the loop interpreted as delay
> in bits. However, inside the loop it gets overwritten by the result of
> mlxsw_sp_pg_buf_delay_get(), and thus leaves the loop as quantity in
> cells. Thus on second and further loop iterations, the headroom for a
> given priority is configured with a wrong size.
> 
> Fix by introducing a loop-local variable, delay_cells. Rename thres to
> thres_cells for consistency.
> 
> Fixes: f417f04da589 ("mlxsw: spectrum: Refactor port buffer configuration")
> Signed-off-by: Petr Machata <petrm@mellanox.com>
> Acked-by: Jiri Pirko <jiri@mellanox.com>
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>

Applied and queued up for -stable, thanks Ido.