From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 164B6C43381 for ; Sun, 17 Feb 2019 21:25:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DFD28217F5 for ; Sun, 17 Feb 2019 21:25:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726435AbfBQVZK (ORCPT ); Sun, 17 Feb 2019 16:25:10 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:41326 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726235AbfBQVZK (ORCPT ); Sun, 17 Feb 2019 16:25:10 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 610181208F8DD; Sun, 17 Feb 2019 13:25:09 -0800 (PST) Date: Sun, 17 Feb 2019 13:25:08 -0800 (PST) Message-Id: <20190217.132508.478042879764829866.davem@davemloft.net> To: vladbu@mellanox.com Cc: netdev@vger.kernel.org, idosch@idosch.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us Subject: Re: [PATCH net-next] net: sched: matchall: verify that filter is not NULL in mall_walk() From: David Miller In-Reply-To: <20190215151756.8719-1-vladbu@mellanox.com> References: <20190215151756.8719-1-vladbu@mellanox.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 17 Feb 2019 13:25:09 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vlad Buslov Date: Fri, 15 Feb 2019 17:17:56 +0200 > Check that filter is not NULL before passing it to tcf_walker->fn() > callback. This can happen when mall_change() failed to offload filter to > hardware. > > Fixes: ed76f5edccc9 ("net: sched: protect filter_chain list with filter_chain_lock mutex") > Reported-by: Ido Schimmel > Tested-by: Ido Schimmel > Signed-off-by: Vlad Buslov Applied.