From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 345E0C43381 for ; Sun, 17 Feb 2019 23:28:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 00BF02184E for ; Sun, 17 Feb 2019 23:28:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727027AbfBQX2O (ORCPT ); Sun, 17 Feb 2019 18:28:14 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:42640 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726283AbfBQX2O (ORCPT ); Sun, 17 Feb 2019 18:28:14 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E1C2512270E59; Sun, 17 Feb 2019 15:28:13 -0800 (PST) Date: Sun, 17 Feb 2019 15:28:13 -0800 (PST) Message-Id: <20190217.152813.935149175146279207.davem@davemloft.net> To: jakub.kicinski@netronome.com Cc: jiri@resnulli.us, netdev@vger.kernel.org, oss-drivers@netronome.com, mkubecek@suse.cz, andrew@lunn.ch Subject: Re: [PATCH net-next 0/3] devlink: add the ability to update device flash From: David Miller In-Reply-To: <20190214214046.19182-1-jakub.kicinski@netronome.com> References: <20190214214046.19182-1-jakub.kicinski@netronome.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 17 Feb 2019 15:28:14 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jakub Kicinski Date: Thu, 14 Feb 2019 13:40:43 -0800 > This series is the second step to allow trouble shooting and recovering > devices in bad state without the use of netdevs as handles. We can > already query FW versions over devlink, now we add the ability to update > the FW. This will allow drivers to implement some from of "limp-mode" > where the device can't really be used for networking and hence has no > netdev, but we can interrogate it over devlink and fix the broken FW. > > Small but nice advantage of devlink is that it only holds the devlink > instance lock during flashing, unlike ethtool which holds rtnl_lock(). Series applied, thanks Jakub. Looking at the feedback, the things requested can be done as follow-ups quite easily.