From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=3zF8=QY=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 33B35C43381
	for <netdev@archiver.kernel.org>; Sun, 17 Feb 2019 04:23:04 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 032C22192C
	for <netdev@archiver.kernel.org>; Sun, 17 Feb 2019 04:23:03 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Lzshkyp/"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730819AbfBQEXC (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Sat, 16 Feb 2019 23:23:02 -0500
Received: from vps0.lunn.ch ([185.16.172.187]:55334 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726168AbfBQEXC (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sat, 16 Feb 2019 23:23:02 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=oVBp11PdPJVegh2jQhhaHjb1c71qsfYDdsx/NxmltJM=; b=Lzshkyp/1ZC6eYmJnZGm8y43n+
        xNw4lGT6BNnRkE6jIT8EaMBFhsps9B4I0HlGMgTDWJ7LW6S99bZmgI3ItCx17IPWZGjHf7thucKcb
        tV1zMvBMRRE45gUVu6mWRFhcUvBzEeNU+iGGA0AkdcMfc1zRmS5Rq6mzy7teqDcZ5Kyk=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1gvDyj-0004rf-VA; Sun, 17 Feb 2019 05:22:57 +0100
Date:   Sun, 17 Feb 2019 05:22:57 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Florian Fainelli <f.fainelli@gmail.com>
Cc:     Heiner Kallweit <hkallweit1@gmail.com>,
        David Miller <davem@davemloft.net>,
        Russell King - ARM Linux <linux@armlinux.org.uk>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 3/4] net: phy: marvell10g: use
 genphy_c45_an_config_an
Message-ID: <20190217042257.GV5699@lunn.ch>
References: <0423e795-0215-053f-57ff-386242a6d7ce@gmail.com>
 <2ad2dd35-45f5-9720-d2ae-0ee104a7d782@gmail.com>
 <2d9ed6ca-60a0-b0da-8e86-f2fd3ef64343@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2d9ed6ca-60a0-b0da-8e86-f2fd3ef64343@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

> This is not strictly equivalent though because marvell10g only checks
> for the 10000baseT_Full bit set whereas genphy_c45_an_config_an() calls
>  linkmode_adv_to_mii_10gbt_adv_t() which you recently updated to also
> check for 2.5G and 5G. This sounds about the right decision, but I
> wonder if Russell did this for a reason (like not able to test 2500baseT
> and 5000baseT?)

Hi Florian

Correct. But both Marvell MAC drivers recently gained the code needed
for 2500BaseX and 5000BaseX. See Maxime and Russell comphy patches.
Russell has tested 2500BaseX SFPs and Maxime has been testing
2500BaseT copper.

	  Andrew