From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36891C43381 for ; Sun, 17 Feb 2019 13:21:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EAE3A21A4A for ; Sun, 17 Feb 2019 13:21:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550409703; bh=UzZbYj8suM3CKWvxnxu5G/ZKx8CMqsbuJ+ar0LZ9E7U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Ws8ElqKCY5y8bzwVE6L1dyMBRp8mRyKFVP0QHuywUeuX+pqVxqJl6aM+wdTFP00X2 ubETONCB/6Z5Xpr0aIw32pChJNdqy5SDUXmEzgPVfYsPN7own5RBemSeNDx1G0RQvJ UfX9DInilBPXlzhUXi2VA0MftWQvL8rY+VfTgtrE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728942AbfBQNVl (ORCPT ); Sun, 17 Feb 2019 08:21:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:46678 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726370AbfBQNVk (ORCPT ); Sun, 17 Feb 2019 08:21:40 -0500 Received: from localhost (unknown [193.47.165.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BDD4F21A4A; Sun, 17 Feb 2019 13:21:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550409700; bh=UzZbYj8suM3CKWvxnxu5G/ZKx8CMqsbuJ+ar0LZ9E7U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=F9P0W9CtaRQr8H+RpN9GpNIpbVMND8m9y3sUHJxXVjCoq902DrFZA9z+JvHAEadgo 3a4Jw6hgZNuFYVZlaNzaHzqD+u32kKLVupsdPUPqIyrMaMUt8PtjMVt1yWTKpBS88M VFcj8wB/FxqSw0vmKAYjoTnghno5YkPLGE3rXvyA= From: Leon Romanovsky To: Saeed Mahameed , "David S . Miller" Cc: Leon Romanovsky , RDMA mailing list , Eyal Davidovich , linux-netdev Subject: [PATCH net-next 1/2] net/mlx5e: Add missing static function annotation Date: Sun, 17 Feb 2019 15:21:27 +0200 Message-Id: <20190217132128.9709-2-leon@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190217132128.9709-1-leon@kernel.org> References: <20190217132128.9709-1-leon@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Leon Romanovsky Compilation with W=1 produces following warning: drivers/net/ethernet/mellanox/mlx5/core/en/monitor_stats.c:69:6: warning: no previous prototype for _mlx5e_monitor_counter_start_ [-Wmissing-prototypes] void mlx5e_monitor_counter_start(struct mlx5e_priv *priv) ^~~~~~~~~~~~~~~~~~~~~~~~~~~ Avoid it by declaring mlx5e_monitor_counter_start() as a static function. Fixes: 5c7e8bbb0257 ("net/mlx5e: Use monitor counters for update stats") Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx5/core/en/monitor_stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/monitor_stats.c b/drivers/net/ethernet/mellanox/mlx5/core/en/monitor_stats.c index 2ce420851e77..7cd5b02e0f10 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/monitor_stats.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/monitor_stats.c @@ -66,7 +66,7 @@ static int mlx5e_monitor_event_handler(struct notifier_block *nb, return NOTIFY_OK; } -void mlx5e_monitor_counter_start(struct mlx5e_priv *priv) +static void mlx5e_monitor_counter_start(struct mlx5e_priv *priv) { MLX5_NB_INIT(&priv->monitor_counters_nb, mlx5e_monitor_event_handler, MONITOR_COUNTER); -- 2.19.1