From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3061C43381 for ; Mon, 18 Feb 2019 20:02:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9E844217F5 for ; Mon, 18 Feb 2019 20:02:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728018AbfBRUCP (ORCPT ); Mon, 18 Feb 2019 15:02:15 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:53580 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725308AbfBRUCP (ORCPT ); Mon, 18 Feb 2019 15:02:15 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D58BE12DE65FA; Mon, 18 Feb 2019 12:02:14 -0800 (PST) Date: Mon, 18 Feb 2019 12:02:14 -0800 (PST) Message-Id: <20190218.120214.624136693999032996.davem@davemloft.net> To: maowenan@huawei.com Cc: netdev@vger.kernel.org, xiyou.wangcong@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2] net: crypto set sk to NULL when af_alg_release. From: David Miller In-Reply-To: <20190218024444.137328-1-maowenan@huawei.com> References: <20190218024444.137328-1-maowenan@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 18 Feb 2019 12:02:15 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Mao Wenan Date: Mon, 18 Feb 2019 10:44:44 +0800 > KASAN has found use-after-free in sockfs_setattr. > The existed commit 6d8c50dcb029 ("socket: close race condition between sock_close() > and sockfs_setattr()") is to fix this simillar issue, but it seems to ignore > that crypto module forgets to set the sk to NULL after af_alg_release. > > KASAN report details as below: > BUG: KASAN: use-after-free in sockfs_setattr+0x120/0x150 > Write of size 4 at addr ffff88837b956128 by task syz-executor0/4186 ... > Fixes: 6d8c50dcb029 ("socket: close race condition between sock_close() and sockfs_setattr()") > Signed-off-by: Mao Wenan Applied and queued up for -stable, thanks.