From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9479C43381 for ; Tue, 19 Feb 2019 00:28:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C15842086D for ; Tue, 19 Feb 2019 00:28:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732346AbfBSA2y (ORCPT ); Mon, 18 Feb 2019 19:28:54 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:56554 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729664AbfBSA2y (ORCPT ); Mon, 18 Feb 2019 19:28:54 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 43BE8108DE823; Mon, 18 Feb 2019 16:28:53 -0800 (PST) Date: Mon, 18 Feb 2019 16:28:50 -0800 (PST) Message-Id: <20190218.162850.1254388175691397706.davem@davemloft.net> To: vkoul@kernel.org Cc: linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, netdev@vger.kernel.org, niklas.cassel@linaro.org, andrew@lunn.ch, f.fainelli@gmail.com, nsekhar@ti.com, peter.ujfalusi@ti.com, marc.w.gonzalez@free.fr Subject: Re: [PATCH v2 1/2] net: phy: at803x: dont inline helpers From: David Miller In-Reply-To: <20190218101853.4290-1-vkoul@kernel.org> References: <20190218101853.4290-1-vkoul@kernel.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 18 Feb 2019 16:28:53 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vinod Koul Date: Mon, 18 Feb 2019 15:48:52 +0530 > Some helpers were inlined, but makes more sense to allow compiler > to do the right optiomazations instead, so remove inline for > at803x_disable_rx_delay() and at803x_disable_tx_delay() > > Signed-off-by: Vinod Koul Two problem with this patch series. 1) It fixes a bug in 'net' but the patches only apply cleanly to 'net-next'. Please respin this against 'net'. 2) This series lacks a header posting "[PATCH vX 0/N] " which explains at a high level what the series is doing, how it is doing it, and why it is doing it that way. Thanks.